Move nfs.conf to a shared library
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | nfs-utils: const-ify all the config handling functionssupport/ support/ | +30 | 0 replies | |
| 2/7 | nfs-utils: Merge conf_get_str and conf_get_sectionsupport/ | +14 | 0 replies | |
| 3/7 | nfs-utils: Move nfs.conf handling into a shared libsupport/ support/ support/ +8 more | +25 | 0 replies | |
| 4/7 | nfs-utils: Add get_str with default valuesupport/ support/ | +12 | 0 replies | |
| 5/7 | nfs-utils: Add pkgconf data for libnfsconfMakefile.am configure.ac libnfsconf.pc.in | +17 | 0 replies | |
| 6/7 | libnfsidmap: Use libnfsconf instead of builtin cfgMakefile.am cfg.c cfg.h +7 more | +18 | 0 replies | |
| 7/7 | libnfsidmap: use conf_get_bool()libnfsidmap.c umich_ldap.c | +7 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] Move nfs.conf to a shared library
A series of small patches to nfs-utils and libnfsidmap in part to continue my work into making an API for accessing nfs.conf and its related config files, but also to address issues brought to light by my previous patches.
nfs-utils and libnfsidmap were using almost identical code to parse their config files, with identical function definitions, which was unmasked when the prototypes changed on one set.
A problem with spaces in config arguments was recently highlighted, this has already been fixed by my previous cleanups in nfs-utils but not in libnfsidmap where it was reported.
Moving the config parsing code out to a shared library fixes both of these issues with minimal code changes. I appreciate that the API this library presents is less than ideal, it was left this way to reduce code changes at this point, and i welcome suggestions for a sympathetic approach to improving it.