Skip to content

net: qualcomm: rmnet: Fix comments on initial patchset

Subash Abhinov Kasiviswanathan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net: qualcomm: rmnet: Fix memory corruption if mux_id is greater than 32drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c+2 -40 replies
2/6net: qualcomm: rmnet: Remove the unused endpoint -1drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+3 -110 replies
3/6net: qualcomm: rmnet: Move the device creation logdrivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c+1 -20 replies
4/6net: qualcomm: rmnet: Refactor the new rmnet dev creationdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.h+26 -840 replies
5/6net: qualcomm: rmnet: Implement ndo_get_iflinkdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c +1 more+15 -30 replies
6/6net: qualcomm: rmnet: Rename real_dev_info to portdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c +5 more+82 -870 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/6] net: qualcomm: rmnet: Fix comments on initial patchset

This series fixes the comments from Dan on the first patch series.

Fixes a memory corruption which could occur if mux_id was higher than 32. Remove the RMNET_LOCAL_LOGICAL_ENDPOINT which is no longer used. Make a log message more useful.
Combine __rmnet_set_endpoint_config() with rmnet_set_endpoint_config(). Set the mux_id in rmnet_vnd_newlink().
Set the ingress and egress data format directly in newlink. Implement ndo_get_iflink to find the real_dev.
Rename the real_dev_info to port to make it similar to other drivers.

The conversion of rmnet_devices to a list and hash lookup will be sent as part of a seperate patch.

Subash Abhinov Kasiviswanathan (6):
net: qualcomm: rmnet: Fix memory corruption if mux_id is greater than

    32

net: qualcomm: rmnet: Remove the unused endpoint -1
net: qualcomm: rmnet: Move the device creation log
net: qualcomm: rmnet: Refactor the new rmnet dev creation
net: qualcomm: rmnet: Implement ndo_get_iflink
net: qualcomm: rmnet: Rename real_dev_info to port

 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 163 +++++++--------------
 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h |   9 +-
 .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c   |  56 +++----
 drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h    |   6 +-
 .../ethernet/qualcomm/rmnet/rmnet_map_command.c    |  13 +-
 .../net/ethernet/qualcomm/rmnet/rmnet_map_data.c   |   3 +-
 .../net/ethernet/qualcomm/rmnet/rmnet_private.h    |   1 -
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c    |  43 +++---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.h    |   6 +-
 9 files changed, 119 insertions(+), 181 deletions(-)
Signature · 1 line
1.9.1