Skip to content

fix reuseaddr regression

[email protected] lkml netdev stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: set tb->fast_sk_familynet/ipv4/inet_connection_sock.c+2 -00 replies
2/3net: use inet6_rcv_saddr to compare socketsnet/ipv4/inet_connection_sock.c+1 -10 replies
3/3inet: fix improper empty comparisonnet/ipv4/inet_connection_sock.c+1 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchCole Robinson
1/3Reported-and-tested-by
2/3Reported-and-tested-by
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] fix reuseaddr regression

I introduced a regression when reworking the fastreuse port stuff that allows bind conflicts to occur once a reuseaddr socket successfully opens on an existing tb. The root cause is I reversed an if statement which caused us to set the tb as if there were no owners on the socket if there were, which obviously is not correct.

Dave I have follow up patches that will add a selftest for this case and I ran the other reuseport related tests as well. These need to go in pretty quickly as it breaks kvm, I've marked them for stable. Sorry for the regression,

Josef