More graceful flusher thread memory reclaim wakeup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 20 repliesIn review
- v16 patches 26 repliesSuperseded
Changes in v2 from the cover letter
- Rename WB_zero_pages to WB_start_all (Amir).
- Remove a test_bit() for a condition where we always expect the bit to be set.
- Remove 'nr_pages' from the wakeup flusher threads helpers, since everybody now passes in zero. Enables further cleanups in later patches too (Jan).
- Fix a case where I forgot to clear WB_start_all if 'work' allocation failed.
- Get rid of cond_resched() in the wb_do_writeback() loop.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | buffer: cleanup free_more_memory() flusher wakeupfs/ | +1 | 1 reply | |
| 2/7 | fs: kill 'nr_pages' argument from wakeup_flusher_threads()fs/ fs/ fs/ +2 more | +8 | 2 replies | |
| 3/7 | fs-writeback: provide a wakeup_flusher_threads_bdi()fs/ include/ | +31 | 1 reply | |
| 4/7 | page-writeback: pass in '0' for nr_pages writeback in laptop modemm/ | +1 | 4 replies | |
| 5/7 | fs-writeback: make wb_start_writeback() staticfs/ include/ | +2 | 1 reply | |
| 6/7 | fs-writeback: move nr_pages == 0 logic to one locationfs/ | +18 | 2 replies | |
| 7/7 | fs-writeback: only allow one inflight and pending full flushfs/ include/ | +25 | 9 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Johannes Weiner | Chris Mason | Jan Kara | Christoph Hellwig |
|---|---|---|---|---|
| 1/7 | A-b | T-b | R-b | R-b |
| 2/7 | R-b | R-b | ||
| 3/7 | A-b | T-b | R-b | R-b |
| 4/7 | A-b | T-b | R-b | R-b |
| 5/7 | A-b | T-b | R-b | R-b |
| 6/7 | A-b | T-b | R-b | R-b |
| 7/7 | A-b | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 0/7 v2] More graceful flusher thread memory reclaim wakeup
We've had some issues with writeback in presence of memory reclaim at Facebook, and this patch set attempts to fix it up. The real functional change is the last patch in the series, the first 5 are prep and cleanup patches.
The basic idea is that we have callers that call wakeup_flusher_threads() with nr_pages == 0. This means 'writeback everything'. For memory reclaim situations, we can end up queuing a TON of these kinds of writeback units. This can cause softlockups and further memory issues, since we allocate huge amounts of struct wb_writeback_work to handle this writeback. Handle this situation more gracefully.
Changes since v1:
- Rename WB_zero_pages to WB_start_all (Amir).
- Remove a test_bit() for a condition where we always expect the bit to be set.
- Remove 'nr_pages' from the wakeup flusher threads helpers, since everybody now passes in zero. Enables further cleanups in later patches too (Jan).
- Fix a case where I forgot to clear WB_start_all if 'work' allocation failed.
- Get rid of cond_resched() in the wb_do_writeback() loop.
Signature · 8 lines
Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>