Writeback improvements
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest12 patches 22 repliesIn review
Changes in v3 from the cover letter
- Removal of non-range_cyclic writeback.
- Cleanup of the buffer.c failure handling code, utilize __GFP_NOFAIL instead of rolling our own.
- Reinstate cyclic writeback for laptop mode, it's now the only option available.
- Rebased on top of master, and series shuffled around.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | buffer: have alloc_page_buffers() use __GFP_NOFAILdrivers/ fs/ fs/ +2 more | +14 | 2 replies | |
| 2/12 | buffer: grow_dev_page() should use __GFP_NOFAIL for all casesfs/ | +1 | 6 replies | |
| 3/12 | buffer: eliminate the need to call free_more_memory() in __getblk_slow()fs/ | +0 | 2 replies | |
| 4/12 | fs: kill 'nr_pages' argument from wakeup_flusher_threads()fs/ fs/ include/ +1 more | +7 | 0 replies | |
| 5/12 | writeback: switch wakeup_flusher_threads() to cyclic writebackfs/ | +1 | 1 reply | |
| 6/12 | writeback: provide a wakeup_flusher_threads_bdi()fs/ include/ | +31 | 0 replies | |
| 7/12 | writeback: pass in '0' for nr_pages writeback in laptop modemm/ | +1 | 0 replies | |
| 8/12 | writeback: make wb_start_writeback() staticfs/ include/ | +2 | 0 replies | |
| 9/12 | writeback: move nr_pages == 0 logic to one locationfs/ | +18 | 0 replies | |
| 10/12 | writeback: only allow one inflight and pending full flushfs/ include/ | +26 | 8 replies | |
| 11/12 | writeback: make sync_inodes_sb() use range cyclic writebackfs/ | +1 | 0 replies | |
| 12/12 | writeback: kill off ->range_cycle optiondrivers/ fs/ fs/ +12 more | +74 | 1 reply |
Reviews trailers per patch
10 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Jan Kara | Christoph Hellwig | Johannes Weiner | Chris Mason | Nikolay Borisov |
|---|---|---|---|---|---|
| 1/12 | R-b | R-b | |||
| 2/12 | R-b | R-b | |||
| 3/12 | R-b | R-b | |||
| 4/12 | R-b | R-b | |||
| 5/12 | R-b | ||||
| 6/12 | R-b | R-b | A-b | T-b | |
| 7/12 | R-b | R-b | A-b | T-b | |
| 8/12 | R-b | R-b | A-b | T-b | |
| 9/12 | R-b | R-b | A-b | T-b | |
| 10/12 | R-b | A-b | T-b | ||
| 11/12 | |||||
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 0/12 v3] Writeback improvements
We've had some issues with writeback in presence of memory reclaim at Facebook, and this patch set attempts to fix it up. The real functional change for that issue is patch 10. The rest are cleanups, as well as the removal of doing non-range cyclic writeback. The users of that was sync_inodes_sb() and wakeup_flusher_threads(), both of which writeback all of the dirty pages.
The basic idea is that we have callers that call wakeup_flusher_threads() with nr_pages == 0. This means 'writeback everything'. For memory reclaim situations, we can end up queuing a TON of these kinds of writeback units. This can cause softlockups and further memory issues, since we allocate huge amounts of struct wb_writeback_work to handle this writeback. Handle this situation more gracefully.
drivers/md/bitmap.c | 2 drivers/staging/lustre/lustre/llite/rw.c | 25 ++----- fs/afs/write.c | 25 +------ fs/btrfs/extent_io.c | 31 ++------- fs/buffer.c | 60 +++--------------- fs/ceph/addr.c | 26 ++----- fs/cifs/file.c | 20 +----- fs/ext4/inode.c | 26 +++---- fs/f2fs/data.c | 26 ++----- fs/fs-writeback.c | 103 +++++++++++++++++++------------ fs/gfs2/aops.c | 27 ++------ fs/ntfs/aops.c | 2 fs/ntfs/mft.c | 2 fs/sync.c | 2 include/linux/backing-dev-defs.h | 1 include/linux/backing-dev.h | 2 include/linux/buffer_head.h | 2 include/linux/writeback.h | 5 - include/trace/events/btrfs.h | 2 include/trace/events/ext4.h | 2 include/trace/events/f2fs.h | 2 include/trace/events/writeback.h | 4 - mm/page-writeback.c | 44 ++----------- mm/vmscan.c | 2 24 files changed, 159 insertions(+), 284 deletions(-)
Changes since v2:
- Removal of non-range_cyclic writeback.
- Cleanup of the buffer.c failure handling code, utilize __GFP_NOFAIL instead of rolling our own.
- Reinstate cyclic writeback for laptop mode, it's now the only option available.
- Rebased on top of master, and series shuffled around.
Changes since v1:
- Rename WB_zero_pages to WB_start_all (Amir).
- Remove a test_bit() for a condition where we always expect the bit to be set.
- Remove 'nr_pages' from the wakeup flusher threads helpers, since everybody now passes in zero. Enables further cleanups in later patches too (Jan).
- Fix a case where I forgot to clear WB_start_all if 'work' allocation failed.
- Get rid of cond_resched() in the wb_do_writeback() loop.
Signature · 1 line
Jens Axboe