Skip to content

lockdep: Add lightweight IRQs disabled/enabled check

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14lockdep: Add IRQs disabled/enabled assertioninclude/linux/lockdep.h+13 -00 replies
2/14irq: Use lockdep to assert IRQs are disabled/enabledkernel/softirq.c+5 -50 replies
3/14workqueue: Use lockdep to assert IRQs are disabled/enabledkernel/workqueue.c+1 -11 reply
4/14nohz: Use lockdep to assert IRQs are disabled/enabledkernel/time/tick-sched.c+2 -30 replies
5/14hrtimer: Use lockdep to assert IRQs are disabled/enabledkernel/time/hrtimer.c+1 -30 replies
6/14smp: Use lockdep to assert IRQs are disabled/enabledkernel/smp.c+1 -10 replies
7/14x86: Use lockdep to assert IRQs are disabled/enabledarch/x86/entry/common.c arch/x86/kernel/smpboot.c+2 -22 replies
8/14perf: Use lockdep to assert IRQs are disabled/enabledkernel/events/core.c+6 -60 replies
9/14irq/timings: Use lockdep to assert IRQs are disabled/enabledkernel/irq/timings.c+1 -10 replies
10/14irq_work: Use lockdep to assert IRQs are disabled/enabledkernel/irq_work.c+1 -10 replies
11/14sched: Use lockdep to assert IRQs are disabled/enabledkernel/sched/clock.c kernel/sched/cputime.c+2 -30 replies
12/14posix-cpu-timers: Use lockdep to assert IRQs are disabled/enabledkernel/time/posix-cpu-timers.c+3 -30 replies
13/14netpoll: Use lockdep to assert IRQs are disabled/enablednet/core/netpoll.c+1 -10 replies
14/14rcu: Use lockdep to assert IRQs are disabled/enabledkernel/rcu/tree.c kernel/rcu/tree_plugin.h+13 -131 reply

Reviews trailers per patch

2 of 14 patches have a Reviewed-by or Acked-by.

PatchTejun HeoPaul E. McKenney
1/14
2/14
3/14A-b
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] lockdep: Add lightweight IRQs disabled/enabled check

Checking whether IRQs are disabled or enabled is often an important sanity check. Now we can be sometimes reluctant to have it on fastpath because reading the flags can be somewhat costly.

As suggested by Peter Zijlstra some time ago, this would be a nice lockdep extension: it's the natural concurrency sanity checker and it already tracks down the irqflags state.

So here it is.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
lockdep/irq

HEAD: 1cb58314de50c73eaf0b0322615ecb7a8ee39592

Thanks,
Frederic
---

Frederic Weisbecker (14):
lockdep: Add IRQs disabled/enabled assertion
irq: Use lockdep to assert IRQs are disabled/enabled
workqueue: Use lockdep to assert IRQs are disabled/enabled
nohz: Use lockdep to assert IRQs are disabled/enabled
hrtimer: Use lockdep to assert IRQs are disabled/enabled
smp: Use lockdep to assert IRQs are disabled/enabled
x86: Use lockdep to assert IRQs are disabled/enabled
perf: Use lockdep to assert IRQs are disabled/enabled irq/timings: Use lockdep to assert IRQs are disabled/enabled
irq_work: Use lockdep to assert IRQs are disabled/enabled
sched: Use lockdep to assert IRQs are disabled/enabled
posix-cpu-timers: Use lockdep to assert IRQs are disabled/enabled
netpoll: Use lockdep to assert IRQs are disabled/enabled
rcu: Use lockdep to assert IRQs are disabled/enabled

 arch/x86/entry/common.c        |  2 +-
 arch/x86/kernel/smpboot.c      |  2 +-
 include/linux/lockdep.h        | 13 +++++++++++++
 kernel/events/core.c           | 12 ++++++------
 kernel/irq/timings.c           |  2 +-
 kernel/irq_work.c              |  2 +-
 kernel/rcu/tree.c              | 16 ++++++++--------
 kernel/rcu/tree_plugin.h       | 10 +++++-----
 kernel/sched/clock.c           |  2 +-
 kernel/sched/cputime.c         |  3 +--
 kernel/smp.c                   |  2 +-
 kernel/softirq.c               | 10 +++++-----
 kernel/time/hrtimer.c          |  4 +---
 kernel/time/posix-cpu-timers.c |  6 +++---
 kernel/time/tick-sched.c       |  5 ++---
 kernel/workqueue.c             |  2 +-
 net/core/netpoll.c             |  2 +-
 17 files changed, 52 insertions(+), 43 deletions(-)