Skip to content

Intel Processor Trace virtualization enabling

Luwei Kang kvm lkml 13 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest12 patches 20 repliesIn review
  2. v2 posting 2/210 patches 39 repliesSuperseded
  3. v912 patches 19 repliesSuperseded
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v812 patches2 repliesSuperseded
v7 posting 2/213 patches3 repliesSuperseded
v7 posting 1/213 patches34 repliesSuperseded
v611 patches5 repliesSuperseded
v511 patches6 repliesSuperseded
v1 posting 2/27 patches59 repliesSuperseded
v411 patches3 repliesApplied
v39 patches10 repliesSuperseded
v2 posting 1/28 patches15 repliesSuperseded
v1 posting 1/26 patches4 repliesSuperseded

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12perf/x86/intel/pt: Move Intel PT MSRs bit defines to global headerarch/x86/events/intel/pt.h arch/x86/include/asm/msr-index.h+33 -370 replies
2/12perf/x86/intel/pt: Export pt_cap_get()arch/x86/events/intel/pt.c arch/x86/events/intel/pt.h arch/x86/include/asm/intel_pt.h+49 -440 replies
3/12perf/x86/intel/pt: Introduce intel_pt_validate_cap()arch/x86/events/intel/pt.c arch/x86/include/asm/intel_pt.h+11 -30 replies
4/12perf/x86/intel/pt: Add new bit definitions for PT MSRsarch/x86/include/asm/msr-index.h+3 -00 replies
5/12perf/x86/intel/pt: add new capability for Intel PTarch/x86/events/intel/pt.c arch/x86/include/asm/intel_pt.h+2 -01 reply
6/12KVM: x86: Add Intel PT virtualization work modearch/x86/include/asm/intel_pt.h arch/x86/include/asm/msr-index.h arch/x86/include/asm/vmx.h +1 more+76 -47 replies
7/12KVM: x86: Add Intel Processor Trace cpuid emulationarch/x86/include/asm/kvm_host.h arch/x86/kvm/cpuid.c arch/x86/kvm/svm.c +1 more+33 -20 replies
8/12KVM: x86: Add Intel PT context switch for each vcpuarch/x86/include/asm/intel_pt.h arch/x86/kvm/vmx.c+96 -012 replies
9/12KVM: x86: Introduce a function to initialize the PT configurationarch/x86/kvm/vmx.c+73 -00 replies
10/12KVM: x86: Implement Intel PT MSRs read/write emulationarch/x86/include/asm/intel_pt.h arch/x86/kvm/vmx.c arch/x86/kvm/x86.c+216 -10 replies
11/12KVM: x86: Set intercept for Intel PT MSRs read/writearch/x86/kvm/vmx.c+23 -00 replies
12/12KVM: x86: Disable Intel PT when VMXON in L1 guestarch/x86/kvm/vmx.c+7 -10 replies

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by.

PatchThomas GleixnerSong Liu
1/12R-b
2/12A-b
3/12A-b
4/12
5/12R-b A-b
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH v13 00/12] Intel Processor Trace virtualization enabling
Quoted 1 line

From V12

- Refine the title and description of patch 1~3. -- Thomas Gleixner
- Rename the function of validate the capabilities of Intel PT. -- Thomas Gleixner
- Add more description of Intel PT work mode. -- Alexander Shishkin

Quoted 1 line

From V11:

- In patch 3, arguments caps vs. cap is not good. Spell second one out. -- Thomas Gleixner

Quoted 1 line

From V10: (This version don't have code change)

- move the patch 5 in version 9 to patch 3 (reorder patch 5) -- Alexander Shishkin
- refind the patch description of patch 5 (add new capability for Intel PT) -- Alexander Shishkin
- CC all the maintainers, reviewers and submitters in each patch of this patch set -- Alexander Shishkin

Quoted 1 line

From V9:

- remove redundant initialize for "ctl_bitmask" in patch 9;
- do some changes for patch's description.

Quoted 1 line

From V8:

- move macro definition MSR_IA32_RTIT_ADDR_RANGE from msr-index.h to intel_pt.h;
- initialize the RTIT_CTL bitmask to ~0ULL.

Quoted 1 line

From V7:

- remove host only mode since it can be emulated by perf code;
- merge patch 8 and 9 to make code and data in the same patch;
- rename __pt_cap_get() to pt_cap_decode();
- other minor change.

Quoted 1 line

From V6:

- split pathes 1~2 to four separate patches (these patches do 2 things) and add more descriptions.

Quoted 1 line

From V5:

- rename the function from pt_cap_get_ex() to __pt_cap_get();
- replace the most of function from vmx_pt_supported() to "pt_mode == PT_MODE_HOST_GUEST"(or !=).

Quoted 1 line

From V4:

- add data check when setting the value of MSR_IA32_RTIT_CTL;
- Invoke new interface to set the intercept of MSRs read/write after "MSR bitmap per-vcpu" patches.

Quoted 1 line

From V3:

- change default mode to SYSTEM mode;
- add a new patch to move PT out of scattered features;
- add a new fucntion kvm_get_pt_addr_cnt() to get the number of address ranges;
- add a new function vmx_set_rtit_ctl() to set the value of guest RTIT_CTL, GUEST_IA32_RTIT_CTL and MSRs intercept.

Quoted 1 line

From v2:

- replace *_PT_SUPPRESS_PIP to *_PT_CONCEAL_PIP;
- clean SECONDARY_EXEC_PT_USE_GPA, VM_EXIT_CLEAR_IA32_RTIT_CTL and VM_ENTRY_LOAD_IA32_RTIT_CTL in SYSTEM mode. These bits must be all set or all clean;
- move processor tracing out of scattered features;
- add a new function to enable/disable intercept MSRs read/write;
- add all Intel PT MSRs read/write and disable intercept when PT is enabled in guest;
- disable Intel PT and enable intercept MSRs when L1 guest VMXON;
- performance optimization.
In Host only mode. we just need to save host RTIT_CTL before vm-entry and restore host RTIT_CTL after vm-exit;
In HOST_GUEST mode. we need to save and restore all MSRs only when PT has enabled in guest.
- use XSAVES/XRESTORES implement context switch.
Haven't implementation in this version and still in debuging. will make a separate patch work on this.

Quoted 1 line

From v1:

- remove guest-only mode because guest-only mode can be covered by host-guest mode;
- always set "use GPA for processor tracing" in secondary execution control if it can be;
- trap RTIT_CTL read/write. Forbid write this msr when VMXON in L1 hypervisor.

Chao Peng (7):
perf/x86/intel/pt: Move Intel PT MSRs bit defines to global header perf/x86/intel/pt: Export pt_cap_get()
KVM: x86: Add Intel PT virtualization work mode
KVM: x86: Add Intel Processor Trace cpuid emulation
KVM: x86: Add Intel PT context switch for each vcpu
KVM: x86: Implement Intel PT MSRs read/write emulation
KVM: x86: Set intercept for Intel PT MSRs read/write

Luwei Kang (5):
perf/x86/intel/pt: Introduce intel_pt_validate_cap() perf/x86/intel/pt: Add new bit definitions for PT MSRs perf/x86/intel/pt: add new capability for Intel PT
KVM: x86: Introduce a function to initialize the PT configuration
KVM: x86: Disable Intel PT when VMXON in L1 guest

 arch/x86/events/intel/pt.c       |  60 +++---
 arch/x86/events/intel/pt.h       |  58 -----
 arch/x86/include/asm/intel_pt.h  |  39 ++++
 arch/x86/include/asm/kvm_host.h  |   1 +
 arch/x86/include/asm/msr-index.h |  37 ++++
 arch/x86/include/asm/vmx.h       |   8 +
 arch/x86/kvm/cpuid.c             |  22 +-
 arch/x86/kvm/svm.c               |   6 +
 arch/x86/kvm/vmx.c               | 446 ++++++++++++++++++++++++++++++++++++++-
 arch/x86/kvm/x86.c               |  33 ++-
 10 files changed, 620 insertions(+), 90 deletions(-)
Signature · 1 line
1.8.3.1