Skip to content

fpga: change api, don't use drive data

Alan Tull linux-fpga lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v3 posting 2/24 patches 4 repliesSuperseded
  3. v3 posting 1/24 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches5 repliesSuperseded
v13 patches7 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4fpga: region: don't use drvdata in common fpga codedrivers/fpga/fpga-region.c drivers/fpga/of-fpga-region.c+1 -10 replies
2/4fpga: manager: change api, don't use drvdataDocumentation/fpga/fpga-mgr.txt drivers/fpga/altera-cvp.c drivers/fpga/altera-pr-ip-core.c +10 more+237 -710 replies
3/4fpga: bridge: change api, don't use drvdatadrivers/fpga/altera-fpga2sdram.c drivers/fpga/altera-freeze-bridge.c drivers/fpga/altera-hps2fpga.c +3 more+123 -450 replies
4/4fpga: region: change api, add fpga_region_create/freeDocumentation/fpga/fpga-region.txt drivers/fpga/fpga-region.c drivers/fpga/of-fpga-region.c +1 more+68 -270 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchMoritz Fischer
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] fpga: change api, don't use drive data

This patchset must go on top of Paolo Pisoli's
"fpga: lattice machxo2: Add Lattice MachXO2 support"

Don't set or use drvdata in the FPGA common manager/bridge/region code.

Change API for manager, bridge, and region to each include functions for create, free, register, and unregister. This involved adding new create/free functions and changing the existing register/unregister functions to take the corresponding manager/bridge/region struct as the only parameter.

Setting drvdata is fine for DT based devices which have one manager, bridge, or region device per platform device. However, PCIe based devices may have multiple FPGA mgr/bridge/regions under one PCIe device. Without these changes, PCIe-based solutions have to create an extra device for each child mgr/bridge/region to hold drvdata.

Alan Tull (4):
fpga: region: don't use drvdata in common fpga code
fpga: manager: change api, don't use drvdata
fpga: bridge: change api, don't use drvdata
fpga: region: change api, add fpga_region_create/free

 Documentation/fpga/fpga-mgr.txt     | 35 +++++++++++++----
 Documentation/fpga/fpga-region.txt  |  3 +-
 drivers/fpga/altera-cvp.c           | 19 ++++++---
 drivers/fpga/altera-fpga2sdram.c    | 21 +++++++---
 drivers/fpga/altera-freeze-bridge.c | 22 +++++++++--
 drivers/fpga/altera-hps2fpga.c      | 24 +++++++++---
 drivers/fpga/altera-pr-ip-core.c    | 18 ++++++++-
 drivers/fpga/altera-ps-spi.c        | 20 ++++++++--
 drivers/fpga/fpga-bridge.c          | 70 +++++++++++++++++++++------------
 drivers/fpga/fpga-mgr.c             | 78 ++++++++++++++++++++++++-------------
 drivers/fpga/fpga-region.c          | 69 +++++++++++++++++++++++++-------
 drivers/fpga/ice40-spi.c            | 21 ++++++++--
 drivers/fpga/machxo2-spi.c          | 20 ++++++++--
 drivers/fpga/of-fpga-region.c       | 14 +++----
 drivers/fpga/socfpga-a10.c          | 14 +++++--
 drivers/fpga/socfpga.c              | 19 +++++++--
 drivers/fpga/ts73xx-fpga.c          | 20 ++++++++--
 drivers/fpga/xilinx-pr-decoupler.c  | 22 ++++++++---
 drivers/fpga/xilinx-spi.c           | 20 ++++++++--
 drivers/fpga/zynq-fpga.c            | 14 +++++--
 include/linux/fpga/fpga-bridge.h    |  9 +++--
 include/linux/fpga/fpga-mgr.h       | 10 +++--
 include/linux/fpga/fpga-region.h    | 11 ++++--
 23 files changed, 429 insertions(+), 144 deletions(-)
Signature · 1 line
2.7.4