Skip to content

Add chrdev and name query support for GLINK

Chris Lew linux-arm-msm linux-devicetree linux-remoteproc lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 3 repliesIn review
  2. v26 patches 0 repliesSuperseded
  3. v16 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- Revert change to make glink attribute table const

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: soc: qcom: Add label for GLINK bindingsDocumentation/devicetree/bindings/soc/qcom/qcom,glink.txt+5 -01 reply
2/6rpmsg: glink: Store edge name for glink devicedrivers/rpmsg/qcom_glink_native.c+6 -00 replies
3/6rpmsg: glink: Use complete_all for open statesdrivers/rpmsg/qcom_glink_native.c+2 -20 replies
4/6rpmsg: Guard against null endpoint ops in destroydrivers/rpmsg/rpmsg_core.c+1 -12 replies
5/6rpmsg: glink: Add support for rpmsg glink chrdevdrivers/rpmsg/qcom_glink_native.c+39 -10 replies
6/6rpmsg: glink: Expose rpmsg name attr for glinkdrivers/rpmsg/qcom_glink_native.c+18 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/6] Add chrdev and name query support for GLINK

Add support for the GLINK rpmsg transport to register a rpmsg chrdev. This will create the rpmsg_ctrl nodes for userspace clients to open rpmsg epts. Create a label property that will help userspace clients distinguish between the different GLINK links. The rpmsg chrdev allocation is done by allocating a local channel which also allocates an ept. We need to add some guards against edge cases for this chrdev because it will never fully open.

Changes since v2:
- Revert change to make glink attribute table const

Changes since v1:
- Add explanation to dt-bindings commit message
- Add patch complete_all the open_req/ack variables
- Add patch to prevent null pointer dereference in chrdev channel release
- Change chrdev allocation to use glink channel allocation
- Change glink attr struct to const

Chris Lew (6):
dt-bindings: soc: qcom: Add label for GLINK bindings
rpmsg: glink: Store edge name for glink device
rpmsg: glink: Use complete_all for open states
rpmsg: Guard against null endpoint ops in destroy
rpmsg: glink: Add support for rpmsg glink chrdev
rpmsg: glink: Expose rpmsg name attr for glink

 .../devicetree/bindings/soc/qcom/qcom,glink.txt    |  5 ++
 drivers/rpmsg/qcom_glink_native.c                  | 68 +++++++++++++++++++++-
 drivers/rpmsg/rpmsg_core.c                         |  2 +-
 3 files changed, 71 insertions(+), 4 deletions(-)
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project