LVM2: fix lvmetad udev rules for CHANGE events
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v1 Latest posting 2/22 patches 2 repliesIn review
- v1 posting 1/20 of 2 patches 0 repliesSuperseded
Patches in v1 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | lvm2: 69-dm-lvm-metad.rules: explicit pvscan ruleudev/ udev/ | +22 | 1 reply | |
| 2/2 | lvm2: 69-dm-lvm-metad.rules: set systemd vars on "change"udev/ udev/ | +44 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RESEND 0/2] LVM2: fix lvmetad udev rules for CHANGE events
(This has been sent to lvm-devel on Dec 21, 2017, and apparently got lost. Resending).
The current logic in 69-dm-lvm-metad.rules is broken for the default "enable-udev-systemd-background-jobs" case. Detailed information about the problem can be found in the commit message of the 2nd patch in the set. That patch also contains the tiny actual change of this patch set: if systemd background jobs are active, the variables SYSTEMD_ALIAS and SYSTEMD_WANTS are also set for CHANGE events, not only for ADD.
The reason that the patch set is quite large nonetheless is that I wanted the comments in the rules file to match the actual behavior. Substitution of multi-line comments is very hard, if not impossible, with the string substitution approach in the current Makefile. That necessitates the first patch, which introduces no functional change.
Martin Wilck (2):
lvm2: 69-dm-lvm-metad.rules: explicit pvscan rule
lvm2: 69-dm-lvm-metad.rules: set systemd vars on "change"
udev/69-dm-lvm-metad.rules.in | 53 +++++++++++++++++++++++++++++++++++++++---- udev/Makefile.in | 9 +++++--- 2 files changed, 54 insertions(+), 8 deletions(-)
Signature · 1 line
2.16.1