Skip to content

drivers: fsi: Fixup SBEFIFO and OCC locking

Eddie James openbmc 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

* lock the mutex around the transfer deletions in sbefifo_remove. Otherwise, it may free memory that sbefifo_worker is accessing.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drivers: fsi: SBEFIFO: switch to workqueue instead of timerdrivers/fsi/fsi-sbefifo.c+32 -220 replies
2/3drivers: fsi: sbefifo: switch to mutex in work functiondrivers/fsi/fsi-sbefifo.c+33 -120 replies
3/3drivers: fsi: occ: switch to irqsave and irqrestoredrivers/fsi/occ.c+25 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH linux dev-4.10 v2 0/3] drivers: fsi: Fixup SBEFIFO and OCC locking

This series provides a couple of fixes designed to make the FSI client drivers play nicely with Jeremy's incoming FSI spinlock changes. Firstly, the SBEFIFO driver must switch to use a workqueue instead of a poll timer so that we can avoid spinlocking the entire function. Therefore, the second patch switches to a mutex instead of a spinlock there. Lastly, switch to irqsave and irqrestore functions in the OCC driver to cleanup the locking there.

Changes since v1:
* lock the mutex around the transfer deletions in sbefifo_remove. Otherwise, it may free memory that sbefifo_worker is accessing.

Eddie James (3):
drivers: fsi: SBEFIFO: switch to workqueue instead of timer
drivers: fsi: sbefifo: switch to mutex in work function
drivers: fsi: occ: switch to irqsave and irqrestore

 drivers/fsi/fsi-sbefifo.c | 97 +++++++++++++++++++++++++++++++----------------
 drivers/fsi/occ.c         | 44 +++++++++++----------
 2 files changed, 89 insertions(+), 52 deletions(-)
Signature · 1 line
1.8.3.1