Skip to content

ip/tunnel: Unify local/remote endpoint address parsing

Serhey Popovych netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 3 repliesSuperseded
  3. v13 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4utils: Introduce and use inet_prefix_reset()include/utils.h ip/iplink_geneve.c ip/iplink_vxlan.c+10 -40 replies
2/4vti/vti6: Unify local/remote endpoint address parsingip/link_vti.c ip/link_vti6.c+40 -300 replies
3/4gre/gre6: Unify local/remote endpoint address parsingip/link_gre.c ip/link_gre6.c+54 -410 replies
4/4iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsingip/link_ip6tnl.c ip/link_iptnl.c+73 -700 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH iproute2-next v3 0/4] ip/tunnel: Unify local/remote endpoint address parsing

Use get_addr_rta() helper to unify address retriveal from netlink message when configuring tunnel and get_addr() to parse endpoint address into @inet_prefix.

This is next step towards ip and ipv6 tunnel module merge: endpoint address parsing code will differ only in @family constant being passed to get_addr_rta() and get_addr().

Reviews, comments and suggestions are welcome.

v3
Rename inet_prefix_reset_flags() to inet_prefix_reset() looks more convenient to hide reset implementation.

v2
Introduce and use inet_prefix_reset_flags() inline helper to initialize @inet_prefix data structure and make code self exmplaining.

Set bitlen to zero in link_iptnl.c when kernel does not send corresponding prefixlen and we configure existing tunnel.

Thanks,
Serhey

Serhey Popovych (4):
utils: Introduce and use inet_prefix_reset()
vti/vti6: Unify local/remote endpoint address parsing gre/gre6: Unify local/remote endpoint address parsing iptnl/ip6tnl: Unify local/remote endpoint and 6rd address parsing

 include/utils.h    |    5 +++
 ip/iplink_geneve.c |    2 +-
 ip/iplink_vxlan.c  |    7 ++--
 ip/link_gre.c      |   57 +++++++++++++++++------------
 ip/link_gre6.c     |   38 ++++++++++---------
 ip/link_ip6tnl.c   |   40 +++++++++++---------
 ip/link_iptnl.c    |  103 ++++++++++++++++++++++++++--------------------------
 ip/link_vti.c      |   32 ++++++++++------
 ip/link_vti6.c     |   38 ++++++++++---------
 9 files changed, 177 insertions(+), 145 deletions(-)
Signature · 1 line
1.7.10.4