Skip to content

drm/simple_kms_helper: Add {enable|disable}_vblank callback support

Oleksandr Andrushchenko dri-devel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/simple_kms_helper: Add {enable|disable}_vblank callback supportdrivers/gpu/drm/drm_simple_kms_helper.c include/drm/drm_simple_kms_helper.h+42 -03 replies
2/4drm/mxsfb: Do not use deprecated drm_driver.{enable|disable)_vblankdrivers/gpu/drm/mxsfb/mxsfb_drv.c+28 -261 reply
3/4drm/tve200: Do not use deprecated drm_driver.{enable|disable)_vblankdrivers/gpu/drm/tve200/tve200_display.c drivers/gpu/drm/tve200/tve200_drm.h drivers/gpu/drm/tve200/tve200_drv.c+8 -72 replies
4/4drm/pl111: Do not use deprecated drm_driver.{enable|disable)_vblankdrivers/gpu/drm/pl111/pl111_display.c drivers/gpu/drm/pl111/pl111_drm.h drivers/gpu/drm/pl111/pl111_drv.c+12 -101 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMarek VasutLinus WalleijEric Anholt
1/4
2/4R-b
3/4R-b
4/4R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] drm/simple_kms_helper: Add {enable|disable}_vblank callback support

From: Oleksandr Andrushchenko <[email protected]>

If simple_kms_helper based driver needs to work with vblanks, then it has to provide drm_driver.{enable|disable}_vblank callbacks, because drm_simple_kms_helper.drm_crtc_funcs does not provide any. At the same time drm_driver.{enable|disable}_vblank callbacks are marked as deprecated and shouldn't be used by new drivers.

Fix this by extending drm_simple_kms_helper.drm_crtc_funcs to provide the missing callbacks.

Please note, that patch for the DRM core (drm_simple_kms_helper.*) is checked at run-time (I use this patch for my own driver), but patches 0002-0004 are compile only checked.

Thank you,
Oleksandr Andrushchenko

Oleksandr Andrushchenko (4):
drm/simple_kms_helper: Add {enable|disable}_vblank callback support drm/mxsfb: Do not use deprecated drm_driver.{enable|disable)_vblank drm/tve200: Do not use deprecated drm_driver.{enable|disable)_vblank drm/pl111: Do not use deprecated drm_driver.{enable|disable)_vblank

 drivers/gpu/drm/drm_simple_kms_helper.c | 24 +++++++++++++++
 drivers/gpu/drm/mxsfb/mxsfb_drv.c       | 54 +++++++++++++++++----------------
 drivers/gpu/drm/pl111/pl111_display.c   | 15 +++++++--
 drivers/gpu/drm/pl111/pl111_drm.h       |  2 --
 drivers/gpu/drm/pl111/pl111_drv.c       |  5 ---
 drivers/gpu/drm/tve200/tve200_display.c | 10 ++++--
 drivers/gpu/drm/tve200/tve200_drm.h     |  2 --
 drivers/gpu/drm/tve200/tve200_drv.c     |  3 --
 include/drm/drm_simple_kms_helper.h     | 18 +++++++++++
 9 files changed, 90 insertions(+), 43 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel