Skip to content

Adding NV12 support

Vidya Srinivas intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drm/i915/skl+: rename skl_wm_values struct to skl_ddb_valuesdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+10 -100 replies
2/16drm/i915/skl+: refactor WM calculation for NV12drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+66 -610 replies
3/16drm/i915/skl+: add NV12 in skl_format_to_fourccdrivers/gpu/drm/i915/intel_display.c+2 -02 replies
4/16drm/i915/skl+: support verification of DDB HW state for NV12drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+43 -110 replies
5/16drm/i915/skl+: NV12 related changes for WMdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+44 -120 replies
6/16drm/i915/skl+: pass skl_wm_level struct to wm compute funcdrivers/gpu/drm/i915/intel_pm.c+7 -110 replies
7/16drm/i915/skl+: make sure higher latency level has higher wm valuedrivers/gpu/drm/i915/intel_pm.c+18 -00 replies
8/16drm/i915/skl+: nv12 workaround disable WM level 1-7drivers/gpu/drm/i915/intel_pm.c+11 -00 replies
9/16drm/i915/skl: split skl_compute_ddb functiondrivers/gpu/drm/i915/intel_pm.c+88 -690 replies
10/16drm/i915: Set scaler mode for NV12drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_atomic.c+7 -20 replies
11/16drm/i915: Update format_is_yuv() to include NV12drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_sprite.c+5 -40 replies
12/16drm/i915: Upscale scaler max scale for NV12drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_sprite.c+33 -130 replies
13/16drm/i915: Add NV12 as supported format for primary planedrivers/gpu/drm/i915/intel_display.c+5 -00 replies
14/16drm/i915: Add NV12 as supported format for sprite planedrivers/gpu/drm/i915/intel_sprite.c+7 -00 replies
15/16drm/i915: Add NV12 support to intel_framebuffer_initdrivers/gpu/drm/i915/intel_display.c+8 -00 replies
16/16drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Regdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c+8 -00 replies

Reviews trailers per patch

11 of 16 patches have a Reviewed-by or Acked-by.

PatchMaarten LankhorstShashank SharmaClinton TaylorMika Kahola
1/16R-b
2/16R-b
3/16R-b
4/16
5/16
6/16R-b
7/16
8/16R-b
9/16
10/16T-b R-b
11/16R-b T-b R-b
12/16T-b R-b
13/16R-b T-b R-b
14/16T-b R-b
15/16T-b R-b
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/16] Adding NV12 support

This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip.
Initial series of the patches can be found here:
https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html

Previous revision history:
The first version of patches were reviewed when floated by Chandra in 2015 but currently there was a design change with respect to
- the way fb offset is handled
- the way rotation is handled
Current NV12 patch series has been ported as per the
current changes on drm-tip

Review comments from Ville (12th June 2017) have been addressed Review comments from Clinton A Taylor (7th July 2017) have been addressed

Review comments from Clinton A Taylor (10th July 2017)
have been addressed. Had missed out tested-by/reviewed-by in the patches.

Fixed that error in this series.
Review comments from Ville (11th July 2017) addressed. Review comments from Paauwe, Bob (29th July 2017) addressed.

Update from rev 28 Aug 2017
Rebased the series.
Tested with IGT for rotation, sprite and tiling combinations. IGT Links:
https://patchwork.kernel.org/patch/9995943/
https://patchwork.kernel.org/patch/9995945/
Review comments by Maarten are addressed in this series. NV12 enabled for Gen10.

Update from last rev:
Review comments from Shashank Sharma are addressed.

Chandra Konduru (6):
drm/i915: Set scaler mode for NV12
drm/i915: Update format_is_yuv() to include NV12 drm/i915: Upscale scaler max scale for NV12 drm/i915: Add NV12 as supported format for primary plane drm/i915: Add NV12 as supported format for sprite plane drm/i915: Add NV12 support to intel_framebuffer_init

Mahesh Kumar (9):
drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values drm/i915/skl+: refactor WM calculation for NV12 drm/i915/skl+: add NV12 in skl_format_to_fourcc drm/i915/skl+: support verification of DDB HW state for NV12 drm/i915/skl+: NV12 related changes for WM drm/i915/skl+: pass skl_wm_level struct to wm compute func drm/i915/skl+: make sure higher latency level has higher wm value drm/i915/skl+: nv12 workaround disable WM level 1-7 drm/i915/skl: split skl_compute_ddb function

Vidya Srinivas (1):
drm/i915: Enable YUV to RGB for Gen10 in Plane Ctrl Reg

 drivers/gpu/drm/i915/i915_drv.h      |  10 +-
 drivers/gpu/drm/i915/i915_reg.h      |   7 +
 drivers/gpu/drm/i915/intel_atomic.c  |   8 +-
 drivers/gpu/drm/i915/intel_display.c |  59 ++++-
 drivers/gpu/drm/i915/intel_drv.h     |   9 +-
 drivers/gpu/drm/i915/intel_pm.c      | 432 ++++++++++++++++++++++-------------
 drivers/gpu/drm/i915/intel_sprite.c  |  18 +-
 7 files changed, 356 insertions(+), 187 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx