generalize build_fadt()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest10 patches 9 repliesIn review
- v19 patches 14 repliesSuperseded
Changes in v2 from the cover letter
* fix typo in "acpi: remove unused acpi-dsdt.aml"
* split ACPI_PORT_SMI_CMD into separate cleanup patch
* s/pm1_/pm1a_/, s/c2_latency/plvl2_lat/, s/c3_latency/plvl3_lat/ and fix conflicts in followup patches caused by renaming
* conditional FIRMWARE_CTRL, DSDT patching is introduced in the patch that makes build_fadt() generic instead of earlier "pc: acpi: isolate FADT specific data into AcpiFadtData structure"
* update comment to mention that build_fadt() supports 5.1 revision
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | acpi: remove unused acpi-dsdt.amlMakefile pc-bios/ | +0 | 0 replies | |
| 2/10 | pc: replace pm object initialization with one-liner in acpi_get_pm_info()hw/ | +1 | 0 replies | |
| 3/10 | acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddressinclude/ | +3 | 0 replies | |
| 4/10 | acpi: add build_append_gas() helper for Generic Address Structurehw/ include/ | +36 | 0 replies | |
| 5/10 | acpi: move ACPI_PORT_SMI_CMD define to header it belongs tohw/ hw/ include/ | +3 | 1 reply | |
| 6/10 | pc: acpi: isolate FADT specific data into AcpiFadtData structurehw/ include/ | +130 | 2 replies | |
| 7/10 | pc: acpi: use build_append_foo() API to construct FADThw/ | +84 | 0 replies | |
| 8/10 | acpi: move build_fadt() from i386 specific to generic ACPI sourcehw/ hw/ hw/ +1 more | +111 | 0 replies | |
| 9/10 | virt_arm: acpi: reuse common build_fadt()hw/ hw/ include/ | +35 | 4 replies | |
| 10/10 | tests: acpi: don't read all fields in test_acpi_fadt_table()include/ tests/ | +18 | 1 reply |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Gerd Hoffmann | Eric Auger | Philippe Mathieu-Daudé |
|---|---|---|---|
| Series | T-b | ||
| 1/10 | R-b | R-b | |
| 2/10 | R-b | R-b | |
| 3/10 | R-b | ||
| 4/10 | R-b | ||
| 5/10 | R-b | ||
| 6/10 | R-b | ||
| 7/10 | R-b | ||
| 8/10 | R-b | ||
| 9/10 | R-b | ||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-arm] [PATCH v2 00/10] generalize build_fadt()
v2:
* fix typo in "acpi: remove unused acpi-dsdt.aml"
* split ACPI_PORT_SMI_CMD into separate cleanup patch
* s/pm1_/pm1a_/, s/c2_latency/plvl2_lat/, s/c3_latency/plvl3_lat/ and fix conflicts in followup patches caused by renaming
* conditional FIRMWARE_CTRL, DSDT patching is introduced in the patch that makes build_fadt() generic instead of earlier "pc: acpi: isolate FADT specific data into AcpiFadtData structure"
* update comment to mention that build_fadt() supports 5.1 revision
Series first cleanups ACPI code around build_fadt() and then converts current packed structure approach to a build_append_FOO() API, getting rid of error prone explicit endianness conversions in code and making build_fadt() look more like APCI table declaration from spec, which should be easier to read/maintain. After that build_fadt() becomes generic enough that we could drop ARM specific implementation and reuse generic build_fadt(), reducing code duplication.
PS: tested only x86 which has make check coverage,
ARM was only slightly tested.
git tree for testing:
https://github.com/imammedo/qemu.git fadt_refactoring_v2
Igor Mammedov (10):
acpi: remove unused acpi-dsdt.aml
pc: replace pm object initialization with one-liner in
acpi_get_pm_info()
acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddress
acpi: add build_append_gas() helper for Generic Address Structure
acpi: move ACPI_PORT_SMI_CMD define to header it belongs to
pc: acpi: isolate FADT specific data into AcpiFadtData structure
pc: acpi: use build_append_foo() API to construct FADT
acpi: move build_fadt() from i386 specific to generic ACPI source
virt_arm: acpi: reuse common build_fadt()
tests: acpi: don't read all fields in test_acpi_fadt_table()
include/hw/acpi/acpi-defs.h | 136 ++++++++---------------------- include/hw/acpi/aml-build.h | 23 ++++++ include/hw/isa/apm.h | 3 + Makefile | 1 - hw/acpi/aml-build.c | 140 +++++++++++++++++++++++++++++++ hw/arm/virt-acpi-build.c | 39 ++++----- hw/i386/acpi-build.c | 196 ++++++++++++++------------------------------ hw/isa/apm.c | 1 - pc-bios/acpi-dsdt.aml | Bin 4405 -> 0 bytes tests/bios-tables-test.c | 82 ++++-------------- 10 files changed, 294 insertions(+), 327 deletions(-) delete mode 100644 pc-bios/acpi-dsdt.aml
Signature · 1 line
2.7.4