Skip to content

generalize build_fadt()

Igor Mammedov qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 9 repliesIn review
  2. v19 patches 14 repliesSuperseded

Changes in v2 from the cover letter

* fix typo in "acpi: remove unused acpi-dsdt.aml"
* split ACPI_PORT_SMI_CMD into separate cleanup patch
* s/pm1_/pm1a_/, s/c2_latency/plvl2_lat/, s/c3_latency/plvl3_lat/ and fix conflicts in followup patches caused by renaming
* conditional FIRMWARE_CTRL, DSDT patching is introduced in the patch that makes build_fadt() generic instead of earlier "pc: acpi: isolate FADT specific data into AcpiFadtData structure"
* update comment to mention that build_fadt() supports 5.1 revision

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10acpi: remove unused acpi-dsdt.amlMakefile pc-bios/acpi-dsdt.aml+0 -10 replies
2/10pc: replace pm object initialization with one-liner in acpi_get_pm_info()hw/i386/acpi-build.c+1 -30 replies
3/10acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddressinclude/hw/acpi/acpi-defs.h+3 -140 replies
4/10acpi: add build_append_gas() helper for Generic Address Structurehw/acpi/aml-build.c include/hw/acpi/aml-build.h+36 -00 replies
5/10acpi: move ACPI_PORT_SMI_CMD define to header it belongs tohw/i386/acpi-build.c hw/isa/apm.c include/hw/isa/apm.h+3 -31 reply
6/10pc: acpi: isolate FADT specific data into AcpiFadtData structurehw/i386/acpi-build.c include/hw/acpi/acpi-defs.h+130 -882 replies
7/10pc: acpi: use build_append_foo() API to construct FADThw/i386/acpi-build.c+84 -620 replies
8/10acpi: move build_fadt() from i386 specific to generic ACPI sourcehw/acpi/aml-build.c hw/arm/virt-acpi-build.c hw/i386/acpi-build.c +1 more+111 -1050 replies
9/10virt_arm: acpi: reuse common build_fadt()hw/acpi/aml-build.c hw/arm/virt-acpi-build.c include/hw/acpi/acpi-defs.h+35 -334 replies
10/10tests: acpi: don't read all fields in test_acpi_fadt_table()include/hw/acpi/acpi-defs.h tests/bios-tables-test.c+18 -1451 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchGerd HoffmannEric AugerPhilippe Mathieu-Daudé
SeriesT-b
1/10R-b R-b
2/10R-b R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-arm] [PATCH v2 00/10] generalize build_fadt()

v2:
* fix typo in "acpi: remove unused acpi-dsdt.aml"
* split ACPI_PORT_SMI_CMD into separate cleanup patch
* s/pm1_/pm1a_/, s/c2_latency/plvl2_lat/, s/c3_latency/plvl3_lat/ and fix conflicts in followup patches caused by renaming
* conditional FIRMWARE_CTRL, DSDT patching is introduced in the patch that makes build_fadt() generic instead of earlier "pc: acpi: isolate FADT specific data into AcpiFadtData structure"
* update comment to mention that build_fadt() supports 5.1 revision

Series first cleanups ACPI code around build_fadt() and then converts current packed structure approach to a build_append_FOO() API, getting rid of error prone explicit endianness conversions in code and making build_fadt() look more like APCI table declaration from spec, which should be easier to read/maintain. After that build_fadt() becomes generic enough that we could drop ARM specific implementation and reuse generic build_fadt(), reducing code duplication.

PS: tested only x86 which has make check coverage,
ARM was only slightly tested.

git tree for testing:
https://github.com/imammedo/qemu.git fadt_refactoring_v2

CC "Michael S. Tsirkin" <[email protected]>
CC Shannon Zhao <[email protected]>
CC Auger Eric <[email protected]>

Igor Mammedov (10):
acpi: remove unused acpi-dsdt.aml
pc: replace pm object initialization with one-liner in

    acpi_get_pm_info()

acpi: reuse AcpiGenericAddress instead of Acpi20GenericAddress
acpi: add build_append_gas() helper for Generic Address Structure
acpi: move ACPI_PORT_SMI_CMD define to header it belongs to
pc: acpi: isolate FADT specific data into AcpiFadtData structure
pc: acpi: use build_append_foo() API to construct FADT
acpi: move build_fadt() from i386 specific to generic ACPI source
virt_arm: acpi: reuse common build_fadt()
tests: acpi: don't read all fields in test_acpi_fadt_table()

 include/hw/acpi/acpi-defs.h | 136 ++++++++----------------------
 include/hw/acpi/aml-build.h |  23 ++++++
 include/hw/isa/apm.h        |   3 +
 Makefile                    |   1 -
 hw/acpi/aml-build.c         | 140 +++++++++++++++++++++++++++++++
 hw/arm/virt-acpi-build.c    |  39 ++++-----
 hw/i386/acpi-build.c        | 196 ++++++++++++++------------------------------
 hw/isa/apm.c                |   1 -
 pc-bios/acpi-dsdt.aml       | Bin 4405 -> 0 bytes
 tests/bios-tables-test.c    |  82 ++++--------------
 10 files changed, 294 insertions(+), 327 deletions(-)
 delete mode 100644 pc-bios/acpi-dsdt.aml
Signature · 1 line
2.7.4