Skip to content

add integrity and security to TPM2 transactions

James Bottomley linux-crypto linux-integrity linux-security-module 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest12 patches 14 repliesIn review
  2. v47 patches 23 repliesSuperseded
  3. v36 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v2 RFC5 patches0 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12tpm-buf: move from static inlines to real functionsdrivers/char/tpm/Makefile drivers/char/tpm/tpm-buf.c drivers/char/tpm/tpm.h+129 -803 replies
2/12tpm-buf: add handling for TPM2B typesdrivers/char/tpm/tpm-buf.c drivers/char/tpm/tpm.h+49 -04 replies
3/12tpm-buf: add cursor based functions for response parsingdrivers/char/tpm/tpm-buf.c drivers/char/tpm/tpm.h+30 -00 replies
4/12tpm2-space: export the context save and load commandsdrivers/char/tpm/tpm.h drivers/char/tpm/tpm2-space.c+8 -40 replies
5/12tpm2-sessions: Add full HMAC and encrypt/decrypt session handlingdrivers/char/tpm/Kconfig drivers/char/tpm/Makefile drivers/char/tpm/tpm-buf.c +5 more+1411 -133 replies
6/12tpm-buf: add tpm_buf_parameters()drivers/char/tpm/tpm-buf.c drivers/char/tpm/tpm.h+12 -00 replies
7/12tpm2: add hmac checks to tpm2_pcr_extend()drivers/char/tpm/tpm2-cmd.c+11 -170 replies
8/12tpm2: add session encryption protection to tpm2_get_random()drivers/char/tpm/tpm2-cmd.c+17 -40 replies
9/12trusted keys: Add session encryption protection to the seal/unseal pathdrivers/char/tpm/tpm2-cmd.c+85 -390 replies
10/12tpm: add the null key name as a tpm2 sysfs variabledrivers/char/tpm/tpm-sysfs.c+26 -10 replies
11/12Documentation: add tpm-security.rstDocumentation/security/tpm/tpm-security.rst+204 -00 replies
12/12tpm2-sessions: NOT FOR COMMITTING add sessions testingdrivers/char/tpm/Makefile drivers/char/tpm/tpm-chip.c drivers/char/tpm/tpm.h +4 more+809 -10 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchArd Biesheuvel
1/12
2/12
3/12
4/12
5/12R-b
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/12] add integrity and security to TPM2 transactions

Link to previous cover letter:

https://lore.kernel.org/linux-integrity/[email protected]/

This is marked v6 instead of v5 because I did a v5 after feedback on v4 but didn't get around to posting it and then had to rework the whole of the kernel space handling while I was on holiday. I also added the documentation of how the whole thing works and the rationale for doing it in tpm-security.rst (patch 11). The main reason for doing this now is so we have something to discuss at Plumbers.

The new patch set implements the various splits requested, but the main changes are that the kernel space is gone and is replaced by a context save and restore of the generated null seed. This is easier to handle than a full kernel space given the new threading for TPM spaces, but conceptually it is still very like a space. I've also made whether integrity and encryption is turned on a Kconfig option.

James

---

James Bottomley (12):
tpm-buf: move from static inlines to real functions
tpm-buf: add handling for TPM2B types
tpm-buf: add cursor based functions for response parsing
tpm2-space: export the context save and load commands
tpm2-sessions: Add full HMAC and encrypt/decrypt session handling
tpm-buf: add tpm_buf_parameters()
tpm2: add hmac checks to tpm2_pcr_extend()
tpm2: add session encryption protection to tpm2_get_random() trusted keys: Add session encryption protection to the seal/unseal
path
tpm: add the null key name as a tpm2 sysfs variable
Documentation: add tpm-security.rst
tpm2-sessions: NOT FOR COMMITTING add sessions testing

 Documentation/security/tpm/tpm-security.rst |  204 +++++
 drivers/char/tpm/Kconfig                    |   11 +
 drivers/char/tpm/Makefile                   |    4 +
 drivers/char/tpm/tpm-buf.c                  |  202 +++++
 drivers/char/tpm/tpm-chip.c                 |    1 +
 drivers/char/tpm/tpm-sysfs.c                |   27 +-
 drivers/char/tpm/tpm.h                      |  117 +--
 drivers/char/tpm/tpm2-cmd.c                 |  202 +++--
 drivers/char/tpm/tpm2-sessions-test.c       |  795 ++++++++++++++++++
 drivers/char/tpm/tpm2-sessions.c            | 1204 +++++++++++++++++++++++++++
 drivers/char/tpm/tpm2-sessions.h            |  138 +++
 drivers/char/tpm/tpm2-space.c               |    8 +-
 include/linux/tpm.h                         |   29 +
 13 files changed, 2787 insertions(+), 155 deletions(-)
 create mode 100644 Documentation/security/tpm/tpm-security.rst
 create mode 100644 drivers/char/tpm/tpm-buf.c
 create mode 100644 drivers/char/tpm/tpm2-sessions-test.c
 create mode 100644 drivers/char/tpm/tpm2-sessions.c
 create mode 100644 drivers/char/tpm/tpm2-sessions.h
Signature · 1 line
2.16.4