Add new CD-ROM related qtests
Status from this message: Thanks, applied to my IDE tree:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyApplied
- v23 patches 9 repliesSuperseded
- v13 patches 10 repliesSuperseded
Changes in v3 from the cover letter
- Rebased to current master branch
- Add a final patch that adds an entry to the MAINTAINERS file
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | tests/boot-sector: Add magic bytes to s390x boot code headertests/ | +6 | 0 replies | |
| 2/4 | tests/cdrom-test: Test booting from CD-ROM ISO image filetests/ tests/ | +166 | 0 replies | |
| 3/4 | tests/cdrom-test: Test that -cdrom parameter is workingtests/ | +58 | 0 replies | |
| 4/4 | MAINTAINERS: Add the cdrom-test to John's sectionMAINTAINERS | +1 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Christian Borntraeger | Philippe Mathieu-Daudé | Michael S. Tsirkin | Hervé Poussineau | Mark Cave-Ayland |
|---|---|---|---|---|---|
| 1/4 | R-b | R-b | R-b | R-b | A-b |
| 2/4 | R-b | R-b | R-b | A-b | |
| 3/4 | R-b | R-b | R-b | A-b | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [Qemu-devel] [PATCH v3 0/4] Add new CD-ROM related qtests
With one of my clean-up patches (see commit 1454509726719e0933c800), I recently accidentially broke the "-cdrom" parameter (more precisely "-drive if=scsi") on a couple of boards, since there was no error detected during the "make check" regression testing. This is clearly an indication that we are lacking tests in this area.
So this small patch series now introduces some tests for CD-ROM drives:
The first two patches introduce the possibility to check that booting from CD-ROM drives still works fine for x86 and s390x, and the third patch adds a test that certain machines can at least still be started with the "-cdrom" parameter (i.e. that test would have catched the mistake that I did with my SCSI cleanup patch).
v3:
- Rebased to current master branch
- Add a final patch that adds an entry to the MAINTAINERS file
v2:
- Use g_spawn_sync() instead of execlp() to run genisoimage
- The "-cdrom" parameter test is now run on all architectures (with machine "none" for the machines that are not explicitly checked)
- Some rewordings and improved comments here and there
Thomas Huth (4):
tests/boot-sector: Add magic bytes to s390x boot code header tests/cdrom-test: Test booting from CD-ROM ISO image file tests/cdrom-test: Test that -cdrom parameter is working
MAINTAINERS: Add the cdrom-test to John's section
MAINTAINERS | 1 + tests/Makefile.include | 2 + tests/boot-sector.c | 9 +- tests/cdrom-test.c | 222 +++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 231 insertions(+), 3 deletions(-) create mode 100644 tests/cdrom-test.c
Signature · 1 line
1.8.3.1