Skip to content

drm/vc4: Atomic color management support

Stefan Schake dri-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v2 posting 2/21 of 3 patches 1 replySuperseded
  3. v2 posting 1/23 of 4 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/vc4: Add some missing HVS register definitions.drivers/gpu/drm/vc4/vc4_regs.h+96 -00 replies
2/4drm/vc4: Expose gamma as atomic propertydrivers/gpu/drm/vc4/vc4_crtc.c+26 -110 replies
3/4drm/vc4: Move CRTC state to headerdrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h+33 -330 replies
4/4drm/vc4: Add CTM supportdrivers/gpu/drm/vc4/vc4_crtc.c drivers/gpu/drm/vc4/vc4_drv.h drivers/gpu/drm/vc4/vc4_kms.c+174 -22 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchStefan Schake
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] drm/vc4: Atomic color management support

This series adds support for the gamma and CTM properties to VC4.

The CTM support is somewhat limited in that we can only enable it for one CRTC at a time and coefficients are S0.9 in hardware. The latter seems good enough for the various color corrections Android offers.

The CTM support in v3 is an entire rewrite from previous versions since I didn't previously model our CTM hardware as private atomic state, which is needed to correctly limit it to one CRTC. Since v2, Eric has also confirmed from the HDL that CTM in VC4 is applied before gamma lut, matching the documented behavior for the DRM property.

Eric Anholt (1):
drm/vc4: Add some missing HVS register definitions.

Stefan Schake (3):
drm/vc4: Expose gamma as atomic property
drm/vc4: Move CRTC state to header
drm/vc4: Add CTM support

 drivers/gpu/drm/vc4/vc4_crtc.c |  74 ++++++++----------
 drivers/gpu/drm/vc4/vc4_drv.h  |  36 +++++++++
 drivers/gpu/drm/vc4/vc4_kms.c  | 167 ++++++++++++++++++++++++++++++++++++++++-
 drivers/gpu/drm/vc4/vc4_regs.h |  96 +++++++++++++++++++++++
 4 files changed, 328 insertions(+), 45 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel