Skip to content

Enable FSGSBASE instructions

Chang S. Bae lkml 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest17 patches 28 repliesIn review
  2. v817 patches 5 repliesSuperseded
  3. v718 patches 16 repliesApplied
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v6 posting 2/212 patches21 repliesSuperseded
v6 posting 1/212 patches0 repliesSuperseded
v513 patches14 repliesSuperseded
v413 patches2 repliesSuperseded
v312 patches31 repliesSuperseded
v215 patches14 repliesSuperseded
v115 patches30 repliesSuperseded

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17x86/ptrace: Prevent ptrace from clearing the FS/GS selectorarch/x86/kernel/ptrace.c+2 -120 replies
2/17selftests/x86/fsgsbase: Test GS selector on ptracer-induced GS base writetools/testing/selftests/x86/fsgsbase.c+15 -60 replies
3/17x86/cpu: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASEDocumentation/admin-guide/kernel-parameters.txt arch/x86/kernel/cpu/common.c+27 -00 replies
4/17x86/entry/64: Clean up paranoid exitarch/x86/entry/entry_64.S+17 -120 replies
5/17x86/entry/64: Switch CR3 before SWAPGS in paranoid entryarch/x86/entry/entry_64.S+19 -120 replies
6/17x86/entry/64: Introduce the FIND_PERCPU_BASE macroarch/x86/entry/calling.h arch/x86/include/asm/inst.h+49 -00 replies
7/17x86/entry/64: Handle FSGSBASE enabled paranoid entry/exitarch/x86/entry/calling.h arch/x86/entry/entry_64.S+75 -90 replies
8/17x86/entry/64: Document GSBASE handling in the paranoid pathDocumentation/x86/entry_64.rst+9 -00 replies
9/17x86/fsgsbase/64: Add intrinsics for FSGSBASE instructionsarch/x86/include/asm/fsgsbase.h+30 -00 replies
10/17x86/fsgsbase/64: Enable FSGSBASE instructions in helper functionsarch/x86/include/asm/fsgsbase.h arch/x86/kernel/process_64.c+70 -150 replies
11/17x86/fsgsbase/64: Use FSGSBASE in switch_to() if availablearch/x86/kernel/process_64.c+28 -60 replies
12/17x86/fsgsbase/64: Use FSGSBASE instructions on thread copy and ptracearch/x86/kernel/process_64.c+9 -60 replies
13/17x86/speculation/swapgs: Check FSGSBASE in enabling SWAPGS mitigationarch/x86/kernel/cpu/bugs.c+2 -40 replies
14/17selftests/x86/fsgsbase: Test ptracer-induced GS base write with FSGSBASEtools/testing/selftests/x86/fsgsbase.c+9 -20 replies
15/17x86/fsgsbase/64: Enable FSGSBASE on 64bit by default and add a chicken bitDocumentation/admin-guide/kernel-parameters.txt arch/x86/kernel/cpu/common.c+15 -200 replies
16/17x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2arch/x86/include/uapi/asm/hwcap2.h arch/x86/kernel/cpu/common.c+6 -10 replies
17/17Documentation/x86/64: Add documentation for GS/FS addressing modeDocumentation/x86/x86_64/fsgs.rst Documentation/x86/x86_64/index.rst+200 -01 reply

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchAndy LutomirskiTony LuckTom LendackyAndi KleenRandy Dunlap
1/17R-b
2/17Originally-by R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b A-b
8/17R-b
9/17R-b R-b R-b
10/17R-b
11/17R-b
12/17R-b
13/17
14/17R-b
15/17R-b
16/17R-b
17/17R-b Originally-by R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/17] Enable FSGSBASE instructions

Benefits:
Currently a user process that wishes to read or write the FS/GS base must make a system call. But recent X86 processors have added new instructions for use in 64-bit mode that allow direct access to the FS and GS segment base addresses. The operating system controls whether applications can use these instructions with a %cr4 control bit.

In addition to benefits to applications, performance improvements to the OS context switch code are possible by making use of these instructions. A third party reported out promising performance numbers out of their initial benchmarking of the previous version of this patch series [9].

Enablement check:
The kernel provides information about the enabled state of FSGSBASE to applications using the ELF_AUX vector. If the HWCAP2_FSGSBASE bit is set in the AUX vector, the kernel has FSGSBASE instructions enabled and applications can use them.

Kernel changes:
Major changes made in the kernel are in context switch, paranoid path, and ptrace. In a context switch, a task's FS/GS base will be secured regardless of its selector. In the paranoid path, GS base is unconditionally overwritten to the kernel GS base on entry and the original GS base is restored on exit. Ptrace includes divergence of FS/GS index and base values.

Security:
For mitigating the Spectre v1 SWAPGS issue, LFENCE instructions were added on most kernel entries. Those patches are dependent on previous behaviors that users couldn't load a kernel address into the GS base. These patches change that assumption since the user can load any address into GS base. The changes to the kernel entry path in this patch series take account of the SWAPGS issue.

Updates from v8 [10]:
* Internalized the interrupt check in the helper functions (Andy L.)
* Simplified GS base helper functions (Tony L.)
* Changed the patch order to put the paranoid path changes before the context switch changes (Tony L.)
* Fixed typos (Randy D.) and massaged a few sentences in the documentation
* Massaged the FSGSBASE enablement message

Previous versions: [1-7]

[1] version 1: https://lkml.kernel.org/r/[email protected]/
[2] version 2: https://lkml.kernel.org/r/[email protected]/
[3] version 3: https://lkml.kernel.org/r/[email protected]/
[4] version 4: https://lkml.kernel.org/r/[email protected]/
[5] version 5: https://lkml.kernel.org/r/[email protected]/
[6] version 6: https://lkml.kernel.org/r/[email protected]/
[7] version 7: https://lkml.kernel.org/r/[email protected]/
[8] previously merged point (right before reverted):

    https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86-cpu-for-linus&id=697096b14444f458fb81212d1c

82d7846e932455
[9] initial benchmark: https://www.phoronix.com/scan.php?page=article&item=linux-wip-fsgsbase&num=1
[10] version 8: https://lore.kernel.org/lkml/[email protected]/

Andi Kleen (2):
x86/fsgsbase/64: Add intrinsics for FSGSBASE instructions x86/elf: Enumerate kernel FSGSBASE capability in AT_HWCAP2

Andy Lutomirski (4):
x86/cpu: Add 'unsafe_fsgsbase' to enable CR4.FSGSBASE x86/entry/64: Clean up paranoid exit
x86/fsgsbase/64: Use FSGSBASE in switch_to() if available x86/fsgsbase/64: Enable FSGSBASE on 64bit by default and add a chicken
bit

Chang S. Bae (9):
x86/ptrace: Prevent ptrace from clearing the FS/GS selector selftests/x86/fsgsbase: Test GS selector on ptracer-induced GS base
write
x86/entry/64: Switch CR3 before SWAPGS in paranoid entry x86/entry/64: Introduce the FIND_PERCPU_BASE macro x86/entry/64: Handle FSGSBASE enabled paranoid entry/exit x86/entry/64: Document GSBASE handling in the paranoid path x86/fsgsbase/64: Enable FSGSBASE instructions in helper functions x86/fsgsbase/64: Use FSGSBASE instructions on thread copy and ptrace selftests/x86/fsgsbase: Test ptracer-induced GS base write with
FSGSBASE

Thomas Gleixner (1):
Documentation/x86/64: Add documentation for GS/FS addressing mode

Tony Luck (1):
x86/speculation/swapgs: Check FSGSBASE in enabling SWAPGS mitigation

 Documentation/admin-guide/kernel-parameters.txt |   2 +
 Documentation/x86/entry_64.rst                  |   9 ++
 Documentation/x86/x86_64/fsgs.rst               | 199 ++++++++++++++++++++++++
 Documentation/x86/x86_64/index.rst              |   1 +
 arch/x86/entry/calling.h                        |  40 +++++
 arch/x86/entry/entry_64.S                       | 134 ++++++++++++----
 arch/x86/include/asm/fsgsbase.h                 |  45 ++++--
 arch/x86/include/asm/inst.h                     |  15 ++
 arch/x86/include/uapi/asm/hwcap2.h              |   3 +
 arch/x86/kernel/cpu/bugs.c                      |   6 +-
 arch/x86/kernel/cpu/common.c                    |  22 +++
 arch/x86/kernel/process_64.c                    | 107 +++++++++++--
 arch/x86/kernel/ptrace.c                        |  14 +-
 tools/testing/selftests/x86/fsgsbase.c          |  24 ++-
 14 files changed, 549 insertions(+), 72 deletions(-)
 create mode 100644 Documentation/x86/x86_64/fsgs.rst
Signature · 1 line
2.7.4