Skip to content

fp-test + hardfloat

Emilio G. Cota qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest14 patches 4 repliesIn review
  2. v315 patches 8 repliesSuperseded
  3. v214 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v114 patches29 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14tests: add fp-test, a floating point test suiteconfigure tests/Makefile.include tests/fp/.gitignore +2 more+1200 -00 replies
2/14fp-test: add muladd variantstests/fp/fp-test.c tests/fp/muladd.fptest+75 -00 replies
3/14softfloat: add float{32, 64}_is_{de, }normalinclude/fpu/softfloat.h+20 -00 replies
4/14target/tricore: use float32_is_denormaltarget/tricore/fpu_helper.c+2 -70 replies
5/14tests/fp: add fp-bench, a collection of simple floating point microbenchmarkstests/fp/.gitignore tests/fp/Makefile tests/fp/fp-bench.c+530 -10 replies
6/14softfloat: rename canonicalize to sf_canonicalizefpu/softfloat.c+5 -50 replies
7/14softfloat: add float{32, 64}_is_zero_or_normalinclude/fpu/softfloat.h+10 -00 replies
8/14fpu: introduce hardfloatfpu/softfloat.c+341 -00 replies
9/14hardfloat: support float32/64 addition and subtractionfpu/softfloat.c+98 -80 replies
10/14hardfloat: support float32/64 multiplicationfpu/softfloat.c+62 -40 replies
11/14hardfloat: support float32/64 divisionfpu/softfloat.c+86 -20 replies
12/14hardfloat: support float32/64 fused multiply-addfpu/softfloat.c+165 -40 replies
13/14hardfloat: support float32/64 square rootfpu/softfloat.c+71 -20 replies
14/14hardfloat: support float32/64 comparisonfpu/softfloat.c+60 -140 replies

Reviews trailers per patch

2 of 14 patches have a Reviewed-by or Acked-by.

PatchBastian KoppelmannAlex Bennée
1/14
2/14
3/14R-b R-b
4/14R-b
5/14
6/14T-b
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 00/14] fp-test + hardfloat

Sending this respin (little more than a rebase) in case there's reviewer bandwidth available until the soft-freeze in 3 weeks.

v3: https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00455.html

Not much has changed since April's v3:

- Rebase to current master, fixing some conflicts.
- Add R-b tags
- Fix a typo in the long "hardfloat" comment.
- Move <system.h> header includes right after #include "qemu/osdep.h" Did this after seeing this message from Eric Blake:
https://lists.nongnu.org/archive/html/qemu-devel/2018-04/msg00831.html

Note: there are some checkpatch errors, but they are false positives.

Perf numbers for fp-bench are in each commit log; numbers for several benchmarks are in the last patch's commit log.

You can fetch this series from:
https://github.com/cota/qemu/tree/hardfloat-v4

Thanks,

Emilio