Skip to content

net: Get rid of 'vlan'

Thomas Huth qemu-devel 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesApplied
  2. v33 patches 5 repliesSuperseded
  3. v23 patches 2 repliesSuperseded

Changes in v4 from the cover letter

- Some rewordings in qemu-doc.texi and qemu-options.hx according to Stefan's and Paolo's suggestions

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3net: Remove the deprecated "vlan" parameterdocs/qdev-device-use.txt hw/core/qdev-properties-system.c include/hw/qdev-properties.h +5 more+22 -1300 replies
2/3net: Get rid of 'vlan' terminology and use 'hub' instead in the source filesnet/hub.c net/slirp.c net/tap.c+9 -100 replies
3/3net: Get rid of 'vlan' terminology and use 'hub' instead in the doc filesqemu-doc.texi+23 -190 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Hajnoczi
SeriesR-b
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan'

The 'vlan' term caused a lot of confusion and misconfigurations in the past. The parameter has been marked as deprecated since QEMU v2.9.0, so it's now time to finally remove the parameter and use the better word "hub" in the remaining spots that actually mean the QEMU emulated hub feature.

v4:
- Some rewordings in qemu-doc.texi and qemu-options.hx according to Stefan's and Paolo's suggestions

v3:
- Some rewordings in qemu-doc and net.json according to Paolo's suggestions

v2:
- Added first patch to actually remove the deprecated 'vlan' parameter (instead of only updating the wording in the sources and docs)

Thomas Huth (3):
net: Remove the deprecated "vlan" parameter
net: Get rid of 'vlan' terminology and use 'hub' instead in the source
files
net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
files

 docs/qdev-device-use.txt         |  3 --
 hw/core/qdev-properties-system.c | 80 ----------------------------------------
 include/hw/qdev-properties.h     |  3 --
 include/net/net.h                |  1 -
 net/hub.c                        |  7 ++--
 net/net.c                        | 12 ++----
 net/slirp.c                      |  8 ++--
 net/tap.c                        |  4 +-
 qapi/net.json                    | 15 ++++----
 qemu-doc.texi                    | 51 ++++++++++++-------------
 qemu-options.hx                  | 29 ++++++---------
 11 files changed, 54 insertions(+), 159 deletions(-)
Signature · 1 line
1.8.3.1