Small fixes for s390x QEMU boot menu
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyIn review
- v24 patches 4 repliesSuperseded
- v14 patches 8 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIESpc-bios/ pc-bios/ pc-bios/ | +5 | 0 replies | |
| 2/4 | pc-bios/s390-ccw: fix loadparm initialization and int conversionhw/ pc-bios/ | +11 | 0 replies | |
| 3/4 | pc-bios/s390-ccw: fix non-sequential boot entries (eckd)pc-bios/ | +20 | 0 replies | |
| 4/4 | pc-bios/s390-ccw: fix non-sequential boot entries (enum)pc-bios/ pc-bios/ pc-bios/ | +28 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Janosch Frank |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | R-b |
| 3/4 | R-b | R-b |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu
Change Log:
v3
- added r-b's
- added check around memset
v2
- added r-b's
- s/zipl_println/zipl_print_entry
- prints entry and returns entry number
- while loop now handles valid_entries
These patches fix the following:
- The QEMU zIPL boot menu does not allow accurate selection of non-sequential entries.
- The QEMU zIPL boot menu does not have all the capabilities of the real zIPL menu (such as commandline args). We should print a different banner to reflect this.
- The loadparm array in main.c can end up being not null terminated when converted to an integer via atoui.
- A loadparm set to an empty string does not allow a boot menu.
Collin Walling (4):
pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES pc-bios/s390-ccw: fix loadparm initialization and int conversion pc-bios/s390-ccw: fix non-sequential boot entries (eckd) pc-bios/s390-ccw: fix non-sequential boot entries (enum)
hw/s390x/ipl.c | 4 ++++ pc-bios/s390-ccw/bootmap.c | 16 +++++++------ pc-bios/s390-ccw/bootmap.h | 2 -- pc-bios/s390-ccw/main.c | 14 +++++------ pc-bios/s390-ccw/menu.c | 58 +++++++++++++++++++++++++++++++-------------- pc-bios/s390-ccw/s390-ccw.h | 4 +++- 6 files changed, 63 insertions(+), 35 deletions(-)
Signature · 1 line
2.7.4