Skip to content

nfs-utils: nfsconf cli tool and code tests

Justin Mitchell linux-nfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 3 repliesIn review
  2. v27 patches 0 repliesSuperseded
  3. v17 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8nfs-utils: Fix minor memory leakssupport/nfs/conffile.c+23 -190 replies
2/8nfs-utils: Make config includes relative to current configsupport/nfs/conffile.c+63 -130 replies
3/8nfs-utils: Use config file name in error messagessupport/nfs/conffile.c+26 -190 replies
4/8nfs-utils: Indicate if config file was missingsupport/include/conffile.h support/nfs/conffile.c+6 -60 replies
5/8nfs-utils: tidy up output of conf_reportsupport/include/conffile.h support/nfs/conffile.c+207 -890 replies
6/8nfs-utils: Add nfsconftool cliMakefile.am configure.ac tools/Makefile.am +2 more+192 -12 replies
7/8nfs-utils: use nfsconftool cli to test library functiontests/nfsconf/01-errors.conf tests/nfsconf/01-errors.exp tests/nfsconf/02-valid.conf +3 more+130 -00 replies
8/8nfs-utils: Add man page for nfsconftool clitools/nfsconf/Makefile.am tools/nfsconf/nfsconftool.man+84 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/8] nfs-utils: nfsconf cli tool and code tests

Apologies for the noise, I missed some files out when I last reposted, so here is an updated and tested version.

v3
Include files that were missed out of v2
Add the man page for nfsconftool

v2
Updated style and commenting to make the code clearer

v1
This series introduces a new cli tool to nfs-utils which provides for the dumping of the current configuration, querying of individual settings in a scripting friendly manner and by extention the scripted testing and verification of nfsconf functionality.

The previously unreferenced conf_report() is modified to produce a sorted output, which allows you to --dump the current config in a way thats easier to diff

As well as some improved error messages a script is included which tests the current config parsing code by supplying various example config files and comparing the results of the --dump output.

The cli tool also allows a simple test to check if a config item has been set, and to retrieve the current value in a way that is easy to call from a shell script.

As the next stage I hope to impliment config setting via the cli tool in order to provide an api for automation and management tools