Skip to content

breakpoint: Rework arch validation

Frederic Weisbecker lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9x86/breakpoint: Split validation into "check" and "commit"arch/x86/kernel/hw_breakpoint.c+72 -650 replies
2/9sh: Remove "struct arch_hw_breakpoint::name" unused fieldarch/sh/include/asm/hw_breakpoint.h arch/sh/kernel/hw_breakpoint.c+0 -80 replies
3/9sh: Split breakpoint validation into "check" and "commit"arch/sh/kernel/hw_breakpoint.c+50 -390 replies
4/9arm: Split breakpoint validation into "check" and "commit"arch/arm/kernel/hw_breakpoint.c+103 -736 replies
5/9xtensa: Split breakpoint validation into "check" and "commit"arch/xtensa/kernel/hw_breakpoint.c+42 -180 replies
6/9arm64: Split breakpoint validation into "check" and "commit"arch/arm64/kernel/hw_breakpoint.c+122 -610 replies
7/9powerpc: Split breakpoint validation into "check" and "commit"arch/powerpc/kernel/hw_breakpoint.c+53 -290 replies
8/9perf/breakpoint: Split breakpoint "check" and "commit"arch/arm/include/asm/hw_breakpoint.h arch/arm/kernel/hw_breakpoint.c arch/arm64/include/asm/hw_breakpoint.h +10 more+48 -1269 replies
9/9perf/breakpoint: Only commit breakpoint to arch upon slot reservation successkernel/events/hw_breakpoint.c+44 -330 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchAndy Lutomirski
1/9Original-patch-by
2/9
3/9
4/9
5/9
6/9
7/9
8/9Original-patch-by
9/9Original-patch-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] breakpoint: Rework arch validation

This is the first round of breakpoint code rework and cleanup. Here we split up architecture validation and commit so that we don't mess up with architecture internals in case attributes are rejected or slot can't be reserved. It also unconfuse the code in general.

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
perf/breakpoint

HEAD: 0a788eff09988e58708c4a3ce7b8441ce3e7df95

Thanks,
Frederic
---

Frederic Weisbecker (9):
x86/breakpoint: Split validation into "check" and "commit"
sh: Remove "struct arch_hw_breakpoint::name" unused field
sh: Split breakpoint validation into "check" and "commit"
arm: Split breakpoint validation into "check" and "commit"
xtensa: Split breakpoint validation into "check" and "commit"
arm64: Split breakpoint validation into "check" and "commit"
powerpc: Split breakpoint validation into "check" and "commit" perf/breakpoint: Split breakpoint "check" and "commit" perf/breakpoint: Only commit breakpoint to arch upon slot reservation success

 arch/arm/include/asm/hw_breakpoint.h     |   5 +-
 arch/arm/kernel/hw_breakpoint.c          | 160 +++++++++++++++-------------
 arch/arm64/include/asm/hw_breakpoint.h   |   5 +-
 arch/arm64/kernel/hw_breakpoint.c        | 173 +++++++++++++++++++------------
 arch/powerpc/include/asm/hw_breakpoint.h |   5 +-
 arch/powerpc/kernel/hw_breakpoint.c      |  66 ++++++------
 arch/sh/include/asm/hw_breakpoint.h      |   6 +-
 arch/sh/kernel/hw_breakpoint.c           | 102 ++++++++----------
 arch/x86/include/asm/hw_breakpoint.h     |   5 +-
 arch/x86/kernel/hw_breakpoint.c          | 140 ++++++++++++-------------
 arch/xtensa/include/asm/hw_breakpoint.h  |   5 +-
 arch/xtensa/kernel/hw_breakpoint.c       |  54 ++++++----
 kernel/events/hw_breakpoint.c            |  78 ++++++++------
 13 files changed, 443 insertions(+), 361 deletions(-)