Skip to content

- "version" parameter

Vladimir Testov grub-devel 1 version In review

Get series with b4
b4 am 1526551.q1U5oPLDOt@icedphoenix

Versions newest first

  1. v1 Latest11 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11fixed height detemination+0 -01 reply
2/11grub-core/gfxmenu/gui_list.c+35 -140 replies
3/11some code cleaninggrub-core/gfxmenu/gui_list.c+22 -100 replies
4/11fix centering the text in selected itemgrub-core/gfxmenu/gui_list.c+16 -30 replies
5/11"item_right_space"grub-core/gfxmenu/gui_list.c+8 -10 replies
6/11print scrollbar in the center slicegrub-core/gfxmenu/gui_list.c+12 -20 replies
7/11scrollbar paddinggrub-core/gfxmenu/gui_list.c+43 -40 replies
8/11scrollbar_thumb_offsetgrub-core/gfxmenu/gui_list.c+17 -00 replies
9/11minmax functions (taken from GRUB2 source code)include/grub/misc.h+3 -01 reply
10/11item_pixmap_stylegrub-core/gfxmenu/gui_list.c+67 -110 replies
11/11some more code cleaninggrub-core/gfxmenu/gui_list.c+23 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH] [0/11] [gfxmenu/list] - "version" parameter

There are plenty of misbehaviours of "bootmenu list" component which I would like to correct.
Many of following patches can break backward compatibility.
So I suggest to make a new parameter of a "bootmenu list" - "version". It equal 0 by default.
If some behaviour would change since version 2.XY then we can use XY as start point for some new behaviour and save previous behaviour at the same time.

So if version is 0 - every behavour is just the same as was before. If version is 1 - the behaviour can change a little. (1 - for future release of 2.01 version)

or it could be 201 version, 202 version etc.

Signature · 4 lines
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
grub-core/gfxmenu/gui_list.c +6 -0
diff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c
@@ -31,6 +31,7 @@
   grub_gui_container_t parent;
   grub_video_rect_t bounds;
   char *id;
+  int list_version;
   int visible;
 
   int icon_width;
@@ -519,6 +520,10 @@
       grub_free (self->theme_dir);
       self->theme_dir = value ? grub_strdup (value) : 0;
     }
+  else if (grub_strcmp (name, "version") == 0)
+    {
+      self->list_version = grub_strtol (value, 0, 10);
+    }
   else if (grub_strcmp (name, "id") == 0)
     {
       grub_free (self->id);
@@ -574,6 +579,7 @@
   self->list.ops = &list_ops;
   self->list.component.ops = &list_comp_ops;
 
+  self->list_version = 0;
   self->visible = 1;
 
   default_font = grub_font_get ("Unknown Regular 16");