breakpoint: Rework arch validation v2
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 11 repliesIn review
Changes since v1 from the cover letter
- Avoid arch code duplication between check and commit. Use a temporary struct arch_hw_breakpoint to fill up arch data on the fly (Mark Rutland)
- Start with a default weak version of hw_breakpoint_arch_parse() that architectures override one by one (Peter Zijlstra, Andy Lutomirski)
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | perf/breakpoint: Split attribute parse and commitkernel/ | +41 | 3 replies | |
| 2/12 | perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace()arch/ arch/ arch/ +10 more | +63 | 0 replies | |
| 3/12 | x86: Implement hw_breakpoint_arch_parse()arch/ arch/ | +35 | 0 replies | |
| 4/12 | powerpc: Implement hw_breakpoint_arch_parse()arch/ arch/ | +26 | 5 replies | |
| 5/12 | arm: Implement hw_breakpoint_arch_parse()arch/ arch/ | +41 | 1 reply | |
| 6/12 | arm64: Implement hw_breakpoint_arch_parse()arch/ arch/ | +45 | 2 replies | |
| 7/12 | sh: Remove "struct arch_hw_breakpoint::name" unused fieldarch/ arch/ | +0 | 0 replies | |
| 8/12 | sh: Implement hw_breakpoint_arch_parse()arch/ arch/ | +24 | 0 replies | |
| 9/12 | xtensa: Implement hw_breakpoint_arch_parse()arch/ arch/ | +17 | 0 replies | |
| 10/12 | perf/breakpoint: Remove default hw_breakpoint_arch_parse()arch/ arch/ arch/ +4 more | +0 | 0 replies | |
| 11/12 | perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot()kernel/ | +5 | 0 replies | |
| 12/12 | perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check()kernel/ | +26 | 0 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by.
| Patch | Andy Lutomirski | Will Deacon | Michael Ellerman | Mark Rutland |
|---|---|---|---|---|
| 1/12 | Original-patch-by | |||
| 2/12 | ||||
| 3/12 | Original-patch-by | |||
| 4/12 | A-b | |||
| 5/12 | A-b | |||
| 6/12 | A-b | A-b | ||
| 7/12 | ||||
| 8/12 | ||||
| 9/12 | ||||
| 10/12 | ||||
| 11/12 | ||||
| 12/12 | Original-patch-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/12] breakpoint: Rework arch validation v2
Changes since v1:
- Avoid arch code duplication between check and commit. Use a temporary struct arch_hw_breakpoint to fill up arch data on the fly (Mark Rutland)
- Start with a default weak version of hw_breakpoint_arch_parse() that architectures override one by one (Peter Zijlstra, Andy Lutomirski)
git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
perf/breakpoint-v2
HEAD: a350174ed8f7240b91ae46933bfe2274d3d03806
--- Summary ---
When we modify a hardware breakpoint, the architecture code fills up the architecture data as the validation of generic attributes progresses. If something goes wrong in the middle, the architecture data changes aren't rolled back and we are left with a halfway fiddled breakpoint.
This set fixes the various misdesigns that back this bad behaviour.
Thanks,
Frederic
---
Frederic Weisbecker (12):
perf/breakpoint: Split attribute parse and commit perf/breakpoint: Pass arch breakpoint struct to arch_check_bp_in_kernelspace()
x86: Implement hw_breakpoint_arch_parse()
powerpc: Implement hw_breakpoint_arch_parse()
arm: Implement hw_breakpoint_arch_parse()
arm64: Implement hw_breakpoint_arch_parse()
sh: Remove "struct arch_hw_breakpoint::name" unused field
sh: Implement hw_breakpoint_arch_parse()
xtensa: Implement hw_breakpoint_arch_parse()
perf/breakpoint: Remove default hw_breakpoint_arch_parse() perf/breakpoint: Pass new breakpoint type to modify_breakpoint_slot() perf/breakpoint: Clean up and consolidate modify_user_hw_breakpoint_check()
arch/arm/include/asm/hw_breakpoint.h | 7 +- arch/arm/kernel/hw_breakpoint.c | 78 +++++++++--------- arch/arm64/include/asm/hw_breakpoint.h | 7 +- arch/arm64/kernel/hw_breakpoint.c | 86 ++++++++++---------- arch/powerpc/include/asm/hw_breakpoint.h | 7 +- arch/powerpc/kernel/hw_breakpoint.c | 47 ++++++----- arch/sh/include/asm/hw_breakpoint.h | 8 +- arch/sh/kernel/hw_breakpoint.c | 53 ++++++------- arch/x86/include/asm/hw_breakpoint.h | 7 +- arch/x86/kernel/hw_breakpoint.c | 131 ++++++++++++++++--------------- arch/xtensa/include/asm/hw_breakpoint.h | 7 +- arch/xtensa/kernel/hw_breakpoint.c | 40 ++++------ kernel/events/hw_breakpoint.c | 92 +++++++++++++--------- 13 files changed, 294 insertions(+), 276 deletions(-)