Skip to content

tracing: Fix bugs on snapshot feature

Masami Hiramatsu linux-kselftest lkml stable 1 version In review

Get series with b4
b4 am 153149923649.11274.14970833360963898112.stgit@devbox

Versions newest first

  1. v1 Latest3 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tracing: Fix double free of event_trigger_datakernel/trace/trace.c kernel/trace/trace.h kernel/trace/trace_events_trigger.c+13 -411 replies
2/3ring_buffer: tracing: Inherit the tracing setting to next ring bufferinclude/linux/ring_buffer.h kernel/trace/ring_buffer.c kernel/trace/trace.c+19 -02 replies
3/3selftests/ftrace: Add snapshot and tracing_on test casetools/testing/selftests/ftrace/test.d/00basic/snapshot.tc+28 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMasami Hiramatsu
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] tracing: Fix bugs on snapshot feature

Hi,

Here is 2 bugfixes and 1 testcase related to ftrace snapshot feature. The 1st one is a double free bug and happens very rare. It happened on my pc when I was cleaning up ftracetest (but not reproducible). Anyway, it was easy to find the root cause because I had a backtrace.
The 2nd one is an odd behavior of snapshotting. Since it is easy to reproduce, I made a kselftest testcase for this bug too.

Thank you,

---

Masami Hiramatsu (3):
[BUGFIX] tracing: Fix double free of event_trigger_data
[BUGFIX] ring_buffer: tracing: Inherit the tracing setting to next ring buffer selftests/ftrace: Add snapshot and tracing_on test case

 include/linux/ring_buffer.h                        |    1 +
 kernel/trace/ring_buffer.c                         |   12 +++++++++
 kernel/trace/trace.c                               |   11 ++++++++
 kernel/trace/trace.h                               |    2 +
 kernel/trace/trace_events_trigger.c                |   10 ++++---
 .../selftests/ftrace/test.d/00basic/snapshot.tc    |   28 ++++++++++++++++++++
 6 files changed, 60 insertions(+), 4 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/00basic/snapshot.tc

--
Masami Hiramatsu (Linaro) <[email protected]>