Skip to content

iommu/vt-d: Add scalable mode support

Lu Baolu linux-iommu lkml 6 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest12 patches 1 replyApplied
  2. v512 patches 11 repliesSuperseded
  3. v412 patches 22 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v312 patches0 repliesSuperseded
v212 patches18 repliesSuperseded
v110 patches3 repliesSuperseded

Changes in v6 from the cover letter

- [02/12] Move pasid table allocation out of lock range and replace GFP_ATOMIC with GFP_KERNEL when allocating the pasid memory.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/12iommu/vt-d: Enumerate the scalable mode capabilityDocumentation/admin-guide/kernel-parameters.txt drivers/iommu/intel-iommu.c include/linux/intel-iommu.h+24 -530 replies
2/12iommu/vt-d: Manage scalalble mode PASID tablesdrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.c drivers/iommu/intel-pasid.h +1 more+97 -310 replies
3/12iommu/vt-d: Move page table helpers into headerdrivers/iommu/intel-iommu.c include/linux/intel-iommu.h+43 -430 replies
4/12iommu/vt-d: Add 256-bit invalidation descriptor supportdrivers/iommu/dmar.c drivers/iommu/intel-svm.c drivers/iommu/intel_irq_remapping.c +1 more+121 -610 replies
5/12iommu/vt-d: Reserve a domain id for FL and PT modesdrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.h+16 -00 replies
6/12iommu/vt-d: Add second level page table interfacedrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.c drivers/iommu/intel-pasid.h +1 more+292 -10 replies
7/12iommu/vt-d: Setup pasid entry for RID2PASID supportdrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.h+21 -00 replies
8/12iommu/vt-d: Pass pasid table to context mappingdrivers/iommu/intel-iommu.c+11 -30 replies
9/12iommu/vt-d: Setup context and enable RID2PASID supportdrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.h include/linux/intel-iommu.h+108 -300 replies
10/12iommu/vt-d: Add first level page table interfacedrivers/iommu/intel-pasid.c drivers/iommu/intel-pasid.h include/linux/intel-iommu.h+92 -00 replies
11/12iommu/vt-d: Shared virtual address in scalable modedrivers/iommu/intel-iommu.c drivers/iommu/intel-pasid.c drivers/iommu/intel-pasid.h +2 more+20 -880 replies
12/12iommu/vt-d: Remove deferred invalidationdrivers/iommu/intel-iommu.c drivers/iommu/intel-svm.c include/linux/intel-iommu.h+0 -540 replies

Reviews trailers per patch

10 of 12 patches have a Reviewed-by or Acked-by.

PatchAshok RajKevin Tian
1/12R-b R-b
2/12R-b
3/12R-b R-b
4/12
5/12
6/12R-b
7/12R-b
8/12R-b R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/12] iommu/vt-d: Add scalable mode support

Hi,

Intel vt-d rev3.0 [1] introduces a new translation mode called 'scalable mode', which enables PASID-granular translations for first level, second level, nested and pass-through modes. The vt-d scalable mode is the key ingredient to enable Scalable I/O Virtualization (Scalable IOV) [2] [3], which allows sharing a device in minimal possible granularity (ADI - Assignable Device Interface). It also includes all the capabilities required to enable Shared Virtual Addressing (SVA). As a result, previous Extended Context (ECS) mode is deprecated (no production ever implements ECS).

Each scalable mode pasid table entry is 64 bytes in length, with fields point to the first level page table and the second level page table. The PGTT (Pasid Granular Translation Type) field is used by hardware to determine the translation type.

          A Scalable Mode            .-------------.
           PASID Entry             .-|             |
       .------------------.      .-| | 1st Level   |
      7|                  |      | | | Page Table  |
       .------------------.      | | |             |
      6|                  |      | | |             |
       '------------------'      | | '-------------'
      5|                  |      | '-------------'
       '------------------'      '-------------'
      4|                  |    ^
       '------------------'   /
      3|                  |  /       .-------------.
       .----.-------.-----. /      .-|             |
      2|    | FLPTR |     |/     .-| | 2nd Level   |
       .----'-------'-----.      | | | Page Table  |
      1|                  |      | | |             |
       .-.-------..------..      | | |             |
      0| | SLPTR || PGTT ||----> | | '-------------'
       '-'-------''------''      | '-------------'
       6             |    0      '-------------'
       3             v
             .------------------------------------.
             | PASID Granular Translation Type    |
             |                                    |
             | 001b: 1st level translation only   |
             | 101b: 2nd level translation only   |
             | 011b: Nested translation           |
             | 100b: Pass through                 |
             '------------------------------------'

This patch series adds the scalable mode support in the Intel IOMMU driver. It will make all the Intel IOMMU features work in scalable mode. The changes are all constrained within the Intel IOMMU driver, as it's purely internal format change.

References:
[1] https://software.intel.com/en-us/download/intel-virtualization-technology-for-directed-io-architecture-specification
[2] https://software.intel.com/en-us/download/intel-scalable-io-virtualization-technical-specification
[3] https://schd.ws/hosted_files/lc32018/00/LC3-SIOV-final.pdf

Change log:
v5->v6:
- [02/12] Move pasid table allocation out of lock range and replace GFP_ATOMIC with GFP_KERNEL when allocating the pasid memory.

v4->v5:
- [04/12] Add a comment to explain why we only print two QWORDs of an invalid descriptor.
- [06/12] Fix domain agaw being less than iommu agaw.
- [09/12] Move data type to local branch.
- [11/12] Hold iommu lock when setup pasid entry for SVM.
- All rebased on top of vt-d branch of iommu tree.

v3->v4:
- Rebase all patches to 4.20-rc1.
- Use the right PASID directory table size.
- Add a function for pass through translation setting up.
- Refine the parameters passed to first level translation mode interface.

v2->v3:
- Rebase all patches on top of vt-d branch of iommu repo.
- Set the pasid directory table size to 1 page for devices which have no pasid support.
- Fix various comments received during v2 review period. All were code style related.

v1->v2:
- Rebase all patches on top of v4.19-rc1;
- Add 256-bit invalidation descriptor support;
- Reserve a domain id for first level and pass-through

    usage to make hardware cache entries more efficiently;

- Various code refinements.

Lu Baolu (12):
iommu/vt-d: Enumerate the scalable mode capability iommu/vt-d: Manage scalalble mode PASID tables iommu/vt-d: Move page table helpers into header iommu/vt-d: Add 256-bit invalidation descriptor support iommu/vt-d: Reserve a domain id for FL and PT modes iommu/vt-d: Add second level page table interface iommu/vt-d: Setup pasid entry for RID2PASID support iommu/vt-d: Pass pasid table to context mapping iommu/vt-d: Setup context and enable RID2PASID support iommu/vt-d: Add first level page table interface iommu/vt-d: Shared virtual address in scalable mode iommu/vt-d: Remove deferred invalidation

 .../admin-guide/kernel-parameters.txt         |  12 +-
 drivers/iommu/dmar.c                          |  91 ++--
 drivers/iommu/intel-iommu.c                   | 351 +++++++-------
 drivers/iommu/intel-pasid.c                   | 449 +++++++++++++++++-
 drivers/iommu/intel-pasid.h                   |  40 +-
 drivers/iommu/intel-svm.c                     | 171 +++----
 drivers/iommu/intel_irq_remapping.c           |   6 +-
 include/linux/intel-iommu.h                   |  75 ++-
 8 files changed, 838 insertions(+), 357 deletions(-)
Signature · 1 line
2.17.1