Skip to content

add some more functionality to RPMH

Raju P.L.S.S.S.N linux-arm-msm linux-pm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 3/33 patches 6 repliesIn review
  2. v3 posting 2/33 patches 0 repliesSuperseded
  3. v3 posting 1/33 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches10 repliesSuperseded
v16 patches0 repliesSuperseded

Changes in v3 from the cover letter

- Simplify TCS locking - added a new patch
- Add lock check to avoid potential race as suggested by Matthias
- Add functionality to RSC controller to disallow active requests if solver mode is not set
- Removed independent patches and posted as separate series[2]

Patches in v3 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drivers: qcom: rpmh-rsc: simplify TCS lockingdrivers/soc/qcom/rpmh-internal.h drivers/soc/qcom/rpmh-rsc.c drivers/soc/qcom/rpmh.c+21 -380 replies
2/3drivers: qcom: rpmh-rsc: return if the controller is idledrivers/soc/qcom/rpmh-internal.h drivers/soc/qcom/rpmh-rsc.c drivers/soc/qcom/rpmh.c +1 more+43 -06 replies
3/3drivers: qcom: rpmh: disallow active requests in solver modedrivers/soc/qcom/rpmh-internal.h drivers/soc/qcom/rpmh-rsc.c drivers/soc/qcom/rpmh.c +1 more+91 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH RESEND v3 0/3] add some more functionality to RPMH

Resending the patches. Kindly review.

Changes in v3:
- Simplify TCS locking - added a new patch
- Add lock check to avoid potential race as suggested by Matthias
- Add functionality to RSC controller to disallow active requests if solver mode is not set
- Removed independent patches and posted as separate series[2]

Changes in v2:
- Remove unnecessary EXPORT_SYMBOL in rpmh-rsc

This set of patches add additional functionality to RPMH drivers[1].

PM drivers can choose to disallow idle modes when RSC controller is busy sending or processing requests. The patches add necessary functions to query the controller status.

The controllers may be in 'solver' state, where they could be in autonomous mode executing low power modes for their hardware and as such are not available for sending active votes. Functionality to get notified about such state and disallow requests for state change in that case is added in these patches.

Please consider reviewing this patchset.

This series is based on other patchset[2]

v1:https://lkml.org/lkml/2018/7/19/213
v2:https://patchwork.kernel.org/cover/10546863/

[1] https://lkml.org/lkml/2018/6/20/519
[2] https://lkml.org/lkml/2019/2/18/714

Lina Iyer (2):
drivers: qcom: rpmh-rsc: return if the controller is idle
drivers: qcom: rpmh: disallow active requests in solver mode

Raju P.L.S.S.S.N (1):
drivers: qcom: rpmh-rsc: simplify TCS locking

 drivers/soc/qcom/rpmh-internal.h |  8 ++-
 drivers/soc/qcom/rpmh-rsc.c      | 91 +++++++++++++++++++++++---------
 drivers/soc/qcom/rpmh.c          | 84 ++++++++++++++++++++++++-----
 include/soc/qcom/rpmh.h          | 10 ++++
 4 files changed, 155 insertions(+), 38 deletions(-)
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of the Code Aurora Forum, hosted by The Linux Foundation.