Skip to content

x86: QEMU side support on MSR based features

Robert Hoo qemu-devel 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 0 repliesNew
  2. v53 patches 9 repliesSuperseded
  3. v43 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches36 repliesSuperseded
v23 patches0 repliesSuperseded
v13 patches0 repliesSuperseded

Changelog from the cover letter

v6: In cpu feature filtering, filter out MSR features whose CPUID feature dependency is not there.
Check feature word type for other accelerator, like hvf, for otherwise it
would return bogus EAX/ECX values in x86_cpu_get_supported_feature_word().
v5: Re-order patches. Complement feature MSR set routines.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctlinclude/sysemu/kvm.h target/i386/kvm.c+82 -00 replies
2/3x86: Data structure changes to support MSR based featurestarget/i386/cpu.c target/i386/cpu.h+159 -530 replies
3/3x86: define a new MSR based feature word -- FEATURE_WORDS_ARCH_CAPABILITIEStarget/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+49 -10 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchEduardo Habkost
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/3] x86: QEMU side support on MSR based features

KVM side has added the framework (kvm.git:d1d93fa90) to support MSR based features. Here is the QEMU part, including data structure changes/expanding, referring functions changes, and the implementations on KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl.

Changelog:
v6: In cpu feature filtering, filter out MSR features whose CPUID feature dependency is not there.
Check feature word type for other accelerator, like hvf, for otherwise it
would return bogus EAX/ECX values in x86_cpu_get_supported_feature_word().
v5: Re-order patches. Complement feature MSR set routines.
v4:
Re-organize patch set to conform to request of individually build pass. Add KVM capability check for KVM_GET_MSR_INDEX_LIST before fetch. Special treatment for MSR_IA32_ARCH_CAPABILITIES.RSBA.
Use more convenient glib wrapper (g_strdup_printf) instead of native
(sprintf).

v3: patch 2&3 in v2 are corrupted. Re-format patches.
v2: coding style changes to pass ./scripts/checkpatch.pl.

Robert Hoo (3):
kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS
system ioctl
x86: Data structure changes to support MSR based features
x86: define a new MSR based feature word --
FEATURE_WORDS_ARCH_CAPABILITIES

 include/sysemu/kvm.h |   2 +
 target/i386/cpu.c    | 234 +++++++++++++++++++++++++++++++++++++++------------
 target/i386/cpu.h    |  15 +++-
 target/i386/kvm.c    |  91 ++++++++++++++++++++
 4 files changed, 289 insertions(+), 53 deletions(-)
Signature · 1 line
1.8.3.1