Skip to content

fs/dcache: Track # of negative dentries

Waiman Long linux-doc linux-fsdevel linux-mm lkml stable 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 3/33 patches 3 repliesIn review
  2. v4 posting 2/33 patches 5 repliesSuperseded
  3. v4 posting 1/33 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v34 patches11 repliesSuperseded
v24 patches0 repliesSuperseded
v12 patches26 repliesSuperseded

Changes in v4 from the cover letter

- Drop patch 4 as it is just a minor optimization.
- Add a cc:stable tag to patch 1.
- Clean up some comments in patch 3.

Patches in v4 posting 3/3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()fs/dcache.c+1 -50 replies
2/3fs: Don't need to put list_lru into its own cachelineinclude/linux/fs.h+5 -40 replies
3/3fs/dcache: Track & report number of negative dentriesDocumentation/sysctl/fs.txt fs/dcache.c include/linux/dcache.h+52 -133 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchDave Chinner
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [RESEND PATCH v4 0/3] fs/dcache: Track # of negative dentries

v3->v4:
- Drop patch 4 as it is just a minor optimization.
- Add a cc:stable tag to patch 1.
- Clean up some comments in patch 3.

v2->v3:
- With confirmation that the dummy array in dentry_stat structure was never a replacement of a previously used field, patch 3 is now reverted back to use one of dummy field as the negative dentry count instead of adding a new field.

v1->v2:
- Clarify what the new nr_dentry_negative per-cpu counter is tracking and open-code the increment and decrement as suggested by Dave Chinner.
- Append the new nr_dentry_negative count as the 7th element of dentry-state instead of replacing one of the dummy entries.
- Remove patch "fs/dcache: Make negative dentries easier to be reclaimed" for now as I need more time to think about what
to do with it.
- Add 2 more patches to address issues found while reviewing the dentry code.
- Add another patch to change the conditional branch of nr_dentry_negative accounting to conditional move so as to reduce the performance impact of the accounting code.

This patchset addresses 2 issues found in the dentry code and adds a new nr_dentry_negative per-cpu counter to track the total number of negative dentries in all the LRU lists.

Patch 1 fixes a bug in the accounting of nr_dentry_unused in shrink_dcache_sb().

Patch 2 removes the ____cacheline_aligned_in_smp tag from super_block LRU lists.

Patch 3 adds the new nr_dentry_negative per-cpu counter.

Various filesystem related tests were run and no statistically significant changes in performance outside of the possible noise range was observed.

Waiman Long (3):
fs/dcache: Fix incorrect nr_dentry_unused accounting in
shrink_dcache_sb()
fs: Don't need to put list_lru into its own cacheline fs/dcache: Track & report number of negative dentries

 Documentation/sysctl/fs.txt | 26 ++++++++++++++++----------
 fs/dcache.c                 | 38 +++++++++++++++++++++++++++++++++-----
 include/linux/dcache.h      |  7 ++++---
 include/linux/fs.h          |  9 +++++----
 4 files changed, 58 insertions(+), 22 deletions(-)
Signature · 1 line
1.8.3.1