Skip to content

clean up DPU for RM refactor

Jeykumar Sankaran dri-devel linux-arm-msm 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest19 patches 1 replyIn review
  2. v519 patches 7 repliesSuperseded

Changes in v6 from the cover letter

- remove parameter checks in RM reserve
- use BIT(x) to define power handle event macros
- avoid head allocation for RM topology

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/msm/dpu: remove debugfs support for misrdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +8 more+0 -3870 replies
2/19drm/msm/dpu: squash power handle event typesdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c +1 more+16 -490 replies
3/19drm/msm/dpu: remove scalar config definitionsdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h+0 -120 replies
4/19drm/msm/dpu: remove resource pool managerdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+0 -2610 replies
5/19drm/msm/dpu: remove ping pong split topology variablesdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+0 -30 replies
6/19drm/msm/dpu: enable master-slave encoders explicitlydrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c+12 -310 replies
7/19drm/msm/dpu: use kms stored hw mdp blockdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c+2 -190 replies
8/19drm/msm/dpu: iterate for assigned hw ctl in virtual encoderdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c+20 -410 replies
9/19drm/msm/dpu: avoid querying for hw intf before assignmentdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c+16 -370 replies
10/19drm/msm/dpu: make crtc get_mixer_width helper staticdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+9 -210 replies
11/19drm/msm/dpu: move hw resource tracking to crtc statedrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+39 -420 replies
12/19drm/msm/dpu: rename hw_ctl to lm_ctldrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+15 -150 replies
13/19drm/msm/dpu: clean up destination scaler residuedrivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +2 more+7 -940 replies
14/19drm/msm/dpu: remove cdm block support from resource managerdrivers/gpu/drm/msm/Makefile drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h +11 more+11 -6400 replies
15/19drm/msm/dpu: remove LOCK/CLEAR support in RMdrivers/gpu/drm/msm/disp/dpu1/dpu_rm.c drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h+2 -390 replies
16/19drm/msm/dpu: remove display H_TILE from encoderdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c+0 -90 replies
17/19drm/msm/dpu: remove RM dependency on connector statedrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h +4 more+26 -710 replies
18/19drm/msm/dpu: relax parameter validation in encodersdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c+0 -260 replies
19/19drm/msm/dpu: remove RM topology definitiondrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h +4 more+52 -1240 replies

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchSean Paul
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/19] clean up DPU for RM refactor

Based on the comments received for the patch series[1] and to make the review process a bit more easy, spliting up the patches for cleanup and resource manager refactor. This series cleans up and prepares the DPU for upcoming RM changes.

[1] https://patchwork.freedesktop.org/series/44669/

changes in v4:
- split clean up changes in separate commits
changes in v5:
- clean up dead code in RM
- remove both topology enums and RM specific topology
- update commit texts with reasons for removal
changes in v6:
- remove parameter checks in RM reserve
- use BIT(x) to define power handle event macros
- avoid head allocation for RM topology

Thanks and Regards,
Jeykumar S.

Jeykumar Sankaran (19):
drm/msm/dpu: remove debugfs support for misr drm/msm/dpu: squash power handle event types drm/msm/dpu: remove scalar config definitions drm/msm/dpu: remove resource pool manager drm/msm/dpu: remove ping pong split topology variables drm/msm/dpu: enable master-slave encoders explicitly drm/msm/dpu: use kms stored hw mdp block drm/msm/dpu: iterate for assigned hw ctl in virtual encoder drm/msm/dpu: avoid querying for hw intf before assignment drm/msm/dpu: make crtc get_mixer_width helper static drm/msm/dpu: move hw resource tracking to crtc state drm/msm/dpu: rename hw_ctl to lm_ctl
drm/msm/dpu: clean up destination scaler residue drm/msm/dpu: remove cdm block support from resource manager drm/msm/dpu: remove LOCK/CLEAR support in RM drm/msm/dpu: remove display H_TILE from encoder drm/msm/dpu: remove RM dependency on connector state drm/msm/dpu: relax parameter validation in encoders drm/msm/dpu: remove RM topology definition

 drivers/gpu/drm/msm/Makefile                       |   1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c           | 467 +++------------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h           | 111 +----
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c        | 216 ++--------
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h        |  10 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h   |  23 +-
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c   |  48 +--
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   | 125 +-----
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     |  56 +--
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |  56 ---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c         | 323 --------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h         | 139 ------
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c         |  14 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h         |   4 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c        |  29 --
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h        |   7 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c          |  29 --
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h          |   7 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h        |  33 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c         |  18 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.h         |  17 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c        |   3 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h        |  16 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   8 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c   |  15 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h   |  14 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c             | 285 +++----------
 drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h             |  44 --
 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h          |   4 -
 29 files changed, 214 insertions(+), 1908 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.h
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno