input: atakbd.c bug fixes
Status from this message: Applied, thank you.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | input: atakbd.c - fix Atari keymapdrivers/ | +26 | 3 replies | |
| 2/2 | input: atakbd.c - fix Atari CapsLock behaviourdrivers/ | +2 | 5 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Michael Schmitz |
|---|---|
| 1/2 | T-b |
| 2/2 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] input: atakbd.c bug fixes
Two bug fixes for the Atari keyboard input driver:
- keymap fixes: multiple keymap errors that had gone unnoticed since migration of the m68k keyboard driver code to the input framework. Correct the wrong keycodes - keymap is stil US but keypad, help and undo keys all generate the correct keycodes now.
- capslock fix: the Atari driver incorrectly assumed that capslock were a toggle key (i.e. sending no break scancodes), and synthesized a make/break keycode pair on each capslock scancode. This resulted in duplicate make/break codes on key release, and capslock functioning as a shift key. Remove code sending make/break pairs to get functional capslock behaviour.
Tested on my own Atari Falcon 030.
TIA for your review. Please CC linux-m68k in replies.
Cheers,
Michael
CC to debian-68k, for consideration at the upcoming m68k hackers meeting.