Skip to content

input: atakbd.c bug fixes

Michael Schmitz linux-input 1 version Applied

Status from this message: Applied, thank you.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2input: atakbd.c - fix Atari keymapdrivers/input/keyboard/atakbd.c+26 -383 replies
2/2input: atakbd.c - fix Atari CapsLock behaviourdrivers/input/keyboard/atakbd.c+2 -85 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchMichael Schmitz
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] input: atakbd.c bug fixes

Two bug fixes for the Atari keyboard input driver:

- keymap fixes: multiple keymap errors that had gone unnoticed since migration of the m68k keyboard driver code to the input framework. Correct the wrong keycodes - keymap is stil US but keypad, help and undo keys all generate the correct keycodes now.

- capslock fix: the Atari driver incorrectly assumed that capslock were a toggle key (i.e. sending no break scancodes), and synthesized a make/break keycode pair on each capslock scancode. This resulted in duplicate make/break codes on key release, and capslock functioning as a shift key. Remove code sending make/break pairs to get functional capslock behaviour.

Tested on my own Atari Falcon 030.

TIA for your review. Please CC linux-m68k in replies.

Cheers,

Michael

CC to debian-68k, for consideration at the upcoming m68k hackers meeting.