Skip to content

RFC i915 pvmmio to improve GVTg performance

Xiaolin Zhang intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915/gvt: add module parameter enable_pvmmiodrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_params.c drivers/gpu/drm/i915/i915_params.h +2 more+35 -35 replies
2/10drm/i915/gvt: get ready of memory for pvmmiodrivers/gpu/drm/i915/i915_drv.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_pvinfo.h +1 more+49 -13 replies
3/10drm/i915/gvt: context submission pvmmio optimizationdrivers/gpu/drm/i915/i915_params.h drivers/gpu/drm/i915/intel_lrc.c+37 -23 replies
4/10drm/i915/gvt: master irq pvmmio optimizationdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_params.h drivers/gpu/drm/i915/i915_pvinfo.h+26 -80 replies
5/10drm/i915/gvt: ppgtt update pvmmio optimizationdrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_params.h drivers/gpu/drm/i915/i915_pvinfo.h+41 -10 replies
6/10drm/i915/gvt: GVTg handle enable_pvmmio PVINFO registerdrivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/gvt/vgpu.c+16 -00 replies
7/10drm/i915/gvt: GVTg read_shared_page implementationdrivers/gpu/drm/i915/gvt/gvt.h drivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/gvt/vgpu.c+22 -10 replies
8/10drm/i915/gvt: GVTg support context submission pvmmio optimizationdrivers/gpu/drm/i915/gvt/handlers.c+12 -00 replies
9/10drm/i915/gvt: GVTg support master irq pvmmio optimizationdrivers/gpu/drm/i915/gvt/handlers.c drivers/gpu/drm/i915/gvt/interrupt.c+17 -40 replies
10/10drm/i915/gvt: GVTg support ppgtt pvmmio optimizationdrivers/gpu/drm/i915/gvt/gtt.c drivers/gpu/drm/i915/gvt/gtt.h drivers/gpu/drm/i915/gvt/handlers.c+338 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/10] i915 pvmmio to improve GVTg performance

To improve GVTg performance, it could reduce the mmio access trap numbers within guest driver in some certain scenarios since mmio access trap will introuduce vm exit/vm enter cost.

the solution in this patch set is to setup a shared memory region which accessed both by guest and GVTg without trap cost. the shared memory region is allocated by guest driver and guest driver will pass the region's memory guest physical address to GVTg through PVINFO register and later GVTg can access this region directly without trap cost to achieve data exchange purpose between guest and GVTg.

in this patch set, 3 kind of pvmmio optimization implemented which is controlled by enable_pvmmio PVINO register with different level flag.
1. workload submission (context submission): reduce 4 traps to 1 trap.
2. master irq: reduce 2 traps to 1 trap.
3. ppgtt update: eliminate the cost of ppgtt write protection.

based on the experiment, the performance was gained 4 percent (average) improvment with regard to both media and 3D workload benchmarks.

based on the pvmmio framework, it could achive more sceneario optimization such as globle GTT update, display plane and water mark update with guest.

Xiaolin Zhang (10):
drm/i915/gvt: add module parameter enable_pvmmio drm/i915/gvt: get ready of memory for pvmmio drm/i915/gvt: context submission pvmmio optimization drm/i915/gvt: master irq pvmmio optimization drm/i915/gvt: ppgtt update pvmmio optimization drm/i915/gvt: GVTg handle enable_pvmmio PVINFO register drm/i915/gvt: GVTg read_shared_page implementation drm/i915/gvt: GVTg support context submission pvmmio optimization drm/i915/gvt: GVTg support master irq pvmmio optimization drm/i915/gvt: GVTg support ppgtt pvmmio optimization

 drivers/gpu/drm/i915/gvt/gtt.c       | 318 +++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/gvt/gtt.h       |   9 +
 drivers/gpu/drm/i915/gvt/gvt.h       |   4 +-
 drivers/gpu/drm/i915/gvt/handlers.c  |  44 ++++-
 drivers/gpu/drm/i915/gvt/interrupt.c |  17 +-
 drivers/gpu/drm/i915/gvt/vgpu.c      |  20 +++
 drivers/gpu/drm/i915/i915_drv.c      |   5 +
 drivers/gpu/drm/i915/i915_drv.h      |   6 +
 drivers/gpu/drm/i915/i915_gem_gtt.c  |  36 ++++
 drivers/gpu/drm/i915/i915_irq.c      |  29 +++-
 drivers/gpu/drm/i915/i915_params.c   |   4 +
 drivers/gpu/drm/i915/i915_params.h   |   4 +-
 drivers/gpu/drm/i915/i915_pvinfo.h   |  43 ++++-
 drivers/gpu/drm/i915/i915_vgpu.c     |  29 +++-
 drivers/gpu/drm/i915/intel_lrc.c     |  37 +++-
 15 files changed, 588 insertions(+), 17 deletions(-)
Signature · 6 lines
1.8.3.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx