Skip to content

update sign-file to use generic engine code

James Bottomley keyrings 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 14 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sign-file: stop referring to the code as main.cscripts/sign-file.c+4 -41 reply
2/4sign-file: remove open coding of ERR_clear_error()scripts/sign-file.c+2 -121 reply
3/4sign-file: add generic built-in engine key supportscripts/sign-file.c+37 -26 replies
4/4sign-file: add explicit engine specificationscripts/sign-file.c+36 -276 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchDavid WoodhouseMark J Cox
1/4A-b
2/4A-b
3/4A-b
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] update sign-file to use generic engine code

This patch does both built in engines and explicitly specified ones as per the discussion we had on the "support other engines" patch.

I think this should satisfy everyone's use case without requiring any change to the current work flow (or even options people use to build and sign modules).

James

---

James Bottomley (4):
sign-file: stop referring to the code as main.c
sign-file: remove open coding of ERR_clear_error()
sign-file: add generic built-in engine key support
sign-file: add explicit engine specification

 scripts/sign-file.c | 90 ++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 62 insertions(+), 28 deletions(-)
Signature · 1 line
2.16.4