Skip to content

cfg80211/mac80211: Add support for TID specific configuration

Tamizh Chelvam linux-wireless 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest6 patches 4 repliesIn review
  2. v96 patches 3 repliesSuperseded
  3. v86 patches 15 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v76 patches1 replySuperseded
v69 patches17 repliesSuperseded
v59 patches6 repliesSuperseded
v49 patches0 repliesSuperseded
v39 patches3 repliesSuperseded
v29 patches5 repliesSuperseded
v14 patches24 repliesSuperseded

Changes in v10 from the cover letter

* Addressed Sergey comments.

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nl80211: Add NL command to support TID speicific configurationsinclude/net/cfg80211.h include/uapi/linux/nl80211.h net/wireless/nl80211.c +2 more+320 -00 replies
2/6nl80211: Add support to configure TID specific retry configurationinclude/net/cfg80211.h include/uapi/linux/nl80211.h net/wireless/nl80211.c+75 -00 replies
3/6nl80211: Add support to configure TID specific AMPDU configurationinclude/net/cfg80211.h include/uapi/linux/nl80211.h net/wireless/nl80211.c+26 -00 replies
4/6nl80211: Add support to configure TID specific RTSCTS configurationinclude/net/cfg80211.h include/uapi/linux/nl80211.h net/wireless/nl80211.c+26 -00 replies
5/6nl80211: Add support to configure TID specific txrate configurationinclude/net/cfg80211.h include/uapi/linux/nl80211.h net/wireless/nl80211.c+89 -170 replies
6/6mac80211: Add api to support configuring TID specific configurationinclude/net/mac80211.h net/mac80211/cfg.c net/mac80211/driver-ops.h+93 -00 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSergey Matyukevich
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCHv10 0/6] cfg80211/mac80211: Add support for TID specific configuration

From: Tamizh chelvam <[email protected]>

Add infrastructure to support per TID configurations like noack policy, retry count, AMPDU control(disable/enable), RTSCTS control(enable/disable) and TX rate mask configurations.
This will be useful for the driver which can supports data TID specific configuration rather than phy level configurations. Here NL80211_CMD_SET_TID_CONFIG added to support this operation by accepting TID configuration.
This command can accept STA mac addreess to make the configuration station specific rather than applying to all the connected stations to the netdev.
And this nested command configuration can accept multiple number of data TID specific configuration in a single command,
enum ieee80211_tid_conf_mask used to notify the driver that which configuration got modified for the TID.

Tamizh chelvam (6):
nl80211: Add NL command to support TID speicific configurations
nl80211: Add support to configure TID specific retry configuration
nl80211: Add support to configure TID specific AMPDU configuration
nl80211: Add support to configure TID specific RTSCTS configuration
nl80211: Add support to configure TID specific txrate configuration
mac80211: Add api to support configuring TID specific configuration

 include/net/cfg80211.h       |   65 ++++++++++
 include/net/mac80211.h       |   10 ++
 include/uapi/linux/nl80211.h |  140 +++++++++++++++++++++
 net/mac80211/cfg.c           |   56 +++++++++
 net/mac80211/driver-ops.h    |   27 ++++
 net/wireless/nl80211.c       |  287 +++++++++++++++++++++++++++++++++++++++---
 net/wireless/rdev-ops.h      |   24 ++++
 net/wireless/trace.h         |   37 ++++++
 8 files changed, 629 insertions(+), 17 deletions(-)

v10:
* Addressed Sergey comments.

v9:
* Modified to accept multiple TIDs.
* Splitted retry_short and retry_long as separate parameter
* Introduced new api to reset tid config

v8:
* Fixed enum typecast warning.

v7:
* Fixed compilation error and removed tid config variables from mac80211

v6:
* Addressed Johannes comments.

v5:
* Fixed possible memleak of 'tid_conf' in nl80211_set_tid_config.

v4:
* Fixed kbuild warnings.

v3:
* Modified "nl80211: Add netlink attribute to configure TID specific tx rate" patch to accept multiple TX rate configuration at a time.
* Modified noack and ampdu variable data type to int in
"mac80211: Add api to support configuring TID specific configuration" patch to store default configuration.
* Modified "ath10k: Add new api to support TID specific configuration" patch to handle default values for noack and ampdu. And added sta pointer sanity check in ath10k_mac_tid_bitrate_config function.
* Fixed "ath10k: Add extended TID configuration support" wmi command parameters assigned part.

v2:
* Added support to accept multiple TID configuration
* Added support to configure TX rate and RTSCTS control

Signature · 1 line
1.7.9.5