net: sched: pie: align PIE implementation with RFC 8033
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 5 repliesIn review
- v27 patches 7 repliesSuperseded
- v18 patches 5 repliesSuperseded
Changes in v3 from the cover letter
- Used div_u64() instead of direct division after explicit type casting as recommended by David
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | net: sched: pie: change value of QUEUE_THRESHOLDnet/ | +1 | 0 replies | |
| 2/7 | net: sched: pie: change default value of pie_params->targetnet/ | +1 | 0 replies | |
| 3/7 | net: sched: pie: change default value of pie_params->tupdatenet/ | +1 | 0 replies | |
| 4/7 | net: sched: pie: change initial value of pie_vars->burst_timenet/ | +2 | 0 replies | |
| 5/7 | net: sched: pie: add more cases to auto-tune alpha and betainclude/ net/ | +33 | 0 replies | |
| 6/7 | net: sched: pie: add derandomization mechanismnet/ | +27 | 0 replies | |
| 7/7 | net: sched: pie: update referencesnet/ | +1 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Dave Taht | Jamal Hadi Salim |
|---|---|---|
| 1/7 | A-b | A-b |
| 2/7 | A-b | A-b |
| 3/7 | A-b | A-b |
| 4/7 | A-b | A-b |
| 5/7 | A-b | A-b |
| 6/7 | A-b | A-b |
| 7/7 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v3 0/7] net: sched: pie: align PIE implementation with RFC 8033
The current implementation of the PIE queuing discipline is according to the IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. However, a lot of necessary modifications and enhancements have been proposed in RFC 8033, which have not yet been incorporated in the source code of Linux. This patch series helps in achieving the same.
Performance tests carried out using Flent [https://flent.org/]
Changes from v2 to v3:
- Used div_u64() instead of direct division after explicit type casting as recommended by David
Changes from v1 to v2:
- Excluded the patch setting PIE dynamically active/inactive as the test results were unsatisfactory
- Fixed a scaling issue when adding more auto-tuning cases which caused local variables to underflow
- Changed the long if/else chain to a loop as suggested by Stephen
- Changed the position of the accu_prob variable in the pie_vars structure as recommended by Stephen
Mohit P. Tahiliani (7):
net: sched: pie: change value of QUEUE_THRESHOLD
net: sched: pie: change default value of pie_params->target
net: sched: pie: change default value of pie_params->tupdate
net: sched: pie: change initial value of pie_vars->burst_time
net: sched: pie: add more cases to auto-tune alpha and beta
net: sched: pie: add derandomization mechanism
net: sched: pie: update references
include/uapi/linux/pkt_sched.h | 2 +- net/sched/sch_pie.c | 107 ++++++++++++++++++++------------- 2 files changed, 66 insertions(+), 43 deletions(-)
Signature · 1 line
2.17.1