Skip to content

s390: vfio: ap: Using GISA for AP Interrupt

Pierre Morel kvm linux-s390 lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v17 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vfio: ap: Add AP Queue Interruption Control facilityarch/s390/tools/gen_facilities.c+1 -00 replies
2/3vfio: ap: ioctl definitions for AP Queue Interrupt Controlinclude/uapi/linux/vfio.h+25 -02 replies
3/3vfio: ap: AP Queue Interrupt Control VFIO ioctl callsdrivers/s390/crypto/vfio_ap_ops.c+109 -14 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchTony Krowiak
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] s390: vfio: ap: Using GISA for AP Interrupt

This patch series handles AP Interrupt using the GISA facility. The patch series is based above the GISA+GIB patch series sent by Michael Mueller.

- We define a new VFIO ioctl to ask the vfio_ap driver to register a interruption for the guest.
- We define the assembler code to register a GISA based interruption for the guest.
- We register to the GIB Alert mechanism and suppress the GISA (firmware) based interrupts from the list of software handled interrupts.

This patch series has been tested with success on z13 and z14 with adjunct processors CEX5[ACP] and CEX6C.

To use, you, of course, need the QEMU patches, which will be sent separately.
Take care of the incompatbility in the ioctl parameters.

Pierre Morel (3):
vfio: ap: Add AP Queue Interruption Control facility
vfio: ap: ioctl definitions for AP Queue Interrupt Control
vfio: ap: AP Queue Interrupt Control VFIO ioctl calls

 arch/s390/tools/gen_facilities.c  |   1 +
 drivers/s390/crypto/vfio_ap_ops.c | 110 +++++++++++++++++++++++++++++++++++++-
 include/uapi/linux/vfio.h         |  25 +++++++++
 3 files changed, 135 insertions(+), 1 deletion(-)
Signature · 18 lines
2.7.4

The goal of the first serie was merely to provide the possibility
to test GISA, and was quite a mess.
This serie is reworked with a simplier interface and almost
the half of LOCs.

Changelog:
(Thanks to Tony:)
- Use explicitely ISC as ioctl parameters
- Use ISC parameter in IRQ disable
- No more changes to the ap_matrix_mdev structure (was isc and map)
- suppress redondant functions
- use standard vfio_ap prefix for functions
- in ioctl use one line to call dedicated ioctl function
(Thanks to Conny:)
- no more complicated structure to int conversions
- Use explicitely apqn as ioctl parameters