Skip to content

Re-initialize DLL when MCLK is gated dynamically

Veerabhadrarao Badiganti linux-arm-msm linux-devicetree linux-mmc lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 3 repliesIn review
  2. v42 patches 1 replySuperseded

Changes in v5 from the cover letter

- Exactly same as V3, posted multiple mails for V4. So to avoid confusion updating it as V5.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: mmc: sdhci-msm: Add SoC-specific compatible stringsDocumentation/devicetree/bindings/mmc/sdhci-msm.txt+17 -41 reply
2/2mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamicallydrivers/mmc/host/sdhci-msm.c+67 -111 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringEvan Green
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH V5 0/2] Re-initialize DLL when MCLK is gated dynamically

On few SDHCI-MSM controllers, the host controller's clock tuning circuit may go out of sync if controller clocks are gated which eventually, result in data CRC and command CRC/timeout errors. To fix this issue, the DLL needs to be re-initialized and restored with its old settings once clocks are ungated. SDHC cotroller on SDM845 SOC has this limitation.

Changes since V4:
- Exactly same as V3, posted multiple mails for V4. So to avoid confusion updating it as V5.

Changes since V3:
- Introduced SoC specific dt compatible string for sdhci-msm controller
- Moved the condition which checks whether tuning is needed or not, to a common function.

Changes since V2:
- Removed an unused variable.
- Renamed the newly introduced flags to be more meaningful.
- Added new dt compatible string for SDM845 SOC.

Changes since V1:
- Replaced dt flag with a dt compatible string to indicate SHDCI-MSM controller varients which need this fix.
- Moved the DLL settings restoration logic from request context to platform driver runtime pm context.

Tested on: sdm845
Veerabhadrarao Badiganti (2):
dt-bindings: mmc: sdhci-msm: Add SoC-specific compatible strings
mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynamically

 .../devicetree/bindings/mmc/sdhci-msm.txt          | 21 ++++--
 drivers/mmc/host/sdhci-msm.c                       | 78 +++++++++++++++++++---
 2 files changed, 84 insertions(+), 15 deletions(-)
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.