Skip to content

net: bcmgenet: fix aborted suspend

Doug Berger lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Removed accidentally included write to HFB register

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: bcmgenet: code movementdrivers/net/ethernet/broadcom/genet/bcmgenet.c+30 -300 replies
2/2net: bcmgenet: abort suspend on errordrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] net: bcmgenet: fix aborted suspend

It is not enough to return an error code from the driver suspend routine. The driver must also restore the device functionality.

This commit corrects the issue introduced by commit 0db55093b566 ("net: bcmgenet: return correct value 'ret' from bcmgenet_power_down") by calling the driver resume function if the suspend function returns an error.

Changes in v2:
- Removed accidentally included write to HFB register

Doug Berger (2):
net: bcmgenet: code movement
net: bcmgenet: abort suspend on error

 drivers/net/ethernet/broadcom/genet/bcmgenet.c     | 63 +++++++++++-----------
 drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c |  2 +
 2 files changed, 35 insertions(+), 30 deletions(-)
Signature · 1 line
2.7.4