Skip to content

fw_cfg: fix boot bootsplash and reboot-timeout error checking

Li Qiang qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 5 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fw_cfg: fix -boot bootsplash error checkinghw/nvram/fw_cfg.c vl.c+14 -231 reply
2/3fw_cfg: fix -boot reboot-timeout error checkinghw/nvram/fw_cfg.c vl.c+14 -151 reply
3/3fw_cfg: make qemu_extra_params_fw locallyhw/nvram/fw_cfg.c include/sysemu/sysemu.h+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarkus ArmbrusterGerd HoffmannPhilippe Mathieu-Daudé
SeriesR-b
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

And also do some code cleanup.
A lot of thanks to Markus's review and advice.

v2: fix some small issue per Markus's review.

Li Qiang (3):
fw_cfg: fix -boot bootsplash error checking
fw_cfg: fix -boot reboot-timeout error checking
fw_cfg: make qemu_extra_params_fw locally

 hw/nvram/fw_cfg.c       | 63 +++++++++++++++++++++----------------------------
 include/sysemu/sysemu.h |  1 -
 vl.c                    |  4 ++--
 3 files changed, 29 insertions(+), 39 deletions(-)
Signature · 1 line
2.11.0