Skip to content

hw: vmmouse: use link property instead of DEFINE_PROP_PTR

Li Qiang qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 8 repliesIn review
  2. v22 patches 7 repliesSuperseded
  3. v12 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw: pc: use TYPE_XXX instead of constant stringshw/i386/pc.c hw/i386/vmmouse.c include/hw/i386/pc.h+6 -41 reply
2/2hw: vmmouse: Use link instead of pointer propertyhw/i386/pc.c hw/i386/vmmouse.c+13 -75 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDarren KennyMarkus ArmbrusterMichael S. TsirkinPhilippe Mathieu-Daudé
SeriesR-b
1/2R-b R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

According https://wiki.qemu.org/Contribute/BiteSizedTasks
the 'DEFINE_PROP_PTR' should be replaced by QOM link property. The first patch replace constant strings with TYPE_XXXX and move some definition to pc.h header file so that the second patch can work.

Change since v2: detail commit message Change since v1: fix some issues per Markus' review

Li Qiang (2):
hw: pc: use TYPE_XXX instead of constant strings
hw: vmmouse: Use link instead of pointer property

 hw/i386/pc.c         |  9 +++++----
 hw/i386/vmmouse.c    | 18 +++++++++++-------
 include/hw/i386/pc.h |  3 +++
 3 files changed, 19 insertions(+), 11 deletions(-)
Signature · 1 line
2.11.0