Skip to content

packed ring virtio-net backends support

[email protected] qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 29 repliesIn review
  2. v311 patches 2 repliesSuperseded
  3. v215 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v116 patches11 repliesSuperseded

Changes in v4 from the cover letter

- add version number to the subject of each patch.(mst)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11virtio: rename structure for packed ringhw/virtio/virtio.c+15 -00 replies
2/11virtio: device/driver area size calculation helper for split ringhw/virtio/virtio.c+10 -60 replies
3/11virtio: initialize packed ring regionhw/virtio/virtio.c+12 -20 replies
4/11virtio: initialize wrap counter for packed ringhw/virtio/virtio.c+3 -00 replies
5/11virtio: queue/descriptor check helpers for packed ringhw/virtio/virtio.c+55 -10 replies
6/11virtio: get avail bytes check for packed ringhw/virtio/virtio.c+179 -184 replies
7/11virtio: fill/flush/pop for packed ringhw/virtio/virtio.c+274 -176 replies
8/11virtio: event suppression support for packed ringhw/virtio/virtio.c+128 -94 replies
9/11virtio-net: update the head descriptor in a chain lastlyhw/net/virtio-net.c+10 -17 replies
10/11virtio: migration support for packed ringhw/virtio/virtio.c+66 -33 replies
11/11virtio: CLI and provide packed ring feature bit by defaulthw/net/vhost_net.c include/hw/virtio/virtio.h+5 -14 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 00/11] packed ring virtio-net backends support

From: Wei Xu <[email protected]>

https://github.com/Whishay/qemu.git

Userspace and vhost-net backend test has been done with upstream kernel in guest.

v3->v4:
- add version number to the subject of each patch.(mst)

v2->v3:
v2/01 - drop it since the header has been synchronized from kernel.(mst & jason) v3/01 - rename 'avail_wrap_counter' to 'last_avail_wrap_counter',
'event_wrap_counter' to 'avail_wrap_counter' to make it easier to understand.(Jason)
- revise commit message.(Jason)
v3/02 - split packed ring areas size calculation to next patch.(Jason)
to not break bisect(Jason).
v3/03 - initialize packed ring region with correct size and attribute.
- remove unnecessary 'else' checks. (Jason)
v3/06 - add commit log.
- replace 'event_wrap-counter' with 'avail_wrap_counter'.
- merge common memory cache size check to virtqueue_get_avail_bytes().(Jason)
- revise memory barrier comment.(Jason)
- check indirect descriptors by desc.len/sizeof(desc).(Jason)
- flip wrap counter with '^=1'.(Jason)
v3/07 - move desc.id/len initialization to the declaration.(Jason)
- flip wrap counter '!' with '^=1'.(Jason)
- add memory barrier comments in commit message.
v3/08 - use offsetof() when writing cache.(Jason)
- avoid duplicated memory region write when turning off event_idx supported notification.(Jason)
- add commit log.(Jason)
- add avail & last_avail wrap counter difference description in commit log.
v3/09 - remove unnecessary used/avail idx/wrap-counter from subsection.
- put new subsection to the end of vmstate_virtio.(Jason)
- squash the two userspace and vhost-net migration patches in v2.(Jason)
v3/10 - reword commit message.
- this is a help not a bug fix so I would like to keep it as a separate patch still.(Proposed a merge it by Jason)
- the virtqueue_fill() is also not like an API so I would prefer not to touch it, please correct me if I did not get it in the right way.(Proposed a squash by Jason)
v3/11 - squash feature bits for user space and vhost kernel/user backends.
- enable packed ring feature bit provision on host by default.(Jason)

Wei Xu (11):
virtio: rename structure for packed ring
virtio: device/driver area size calculation helper for split ring
virtio: initialize packed ring region
virtio: initialize wrap counter for packed ring
virtio: queue/descriptor check helpers for packed ring
virtio: get avail bytes check for packed ring
virtio: fill/flush/pop for packed ring
virtio: event suppression support for packed ring
virtio-net: update the head descriptor in a chain lastly
virtio: migration support for packed ring
virtio: CLI and provide packed ring feature bit by default

 hw/net/vhost_net.c         |   2 +
 hw/net/virtio-net.c        |  11 +-
 hw/virtio/virtio.c         | 798 +++++++++++++++++++++++++++++++++++++++++----
 include/hw/virtio/virtio.h |   4 +-
 4 files changed, 757 insertions(+), 58 deletions(-)
Signature · 1 line
1.8.3.1