Skip to content

Assume GCC v4.8 and Clang v3.4 as minimum compiler

Thomas Huth qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 4 repliesIn review
  2. v17 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- Don't remove CONFIG_INT128 sections, they are still required for 32-bit hosts
- Check for Apple's Xcode version of Clang

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7configure: Add a test for the minimum compiler versionconfigure+25 -01 reply
2/7configure: Remove obsolete check for Clang < 3.2configure+0 -51 reply
3/7configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]Makefile.target configure+0 -301 reply
4/7tcg/tcg.h: Remove GCC check for tcg_debug_assert() macrotcg/tcg.h+1 -30 replies
5/7audio/alsaaudio: Remove compiler check around pragmaaudio/alsaaudio.c+0 -21 reply
6/7includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"include/qemu/compiler.h include/qemu/host-utils.h+3 -30 replies
7/7Remove QEMU_ARTIFICIAL macroinclude/qemu/compiler.h scripts/checkpatch.pl scripts/cocci-macro-file.h+0 -80 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH for-4.0 v2 0/7] Assume GCC v4.8 and Clang v3.4 as minimum compiler

It's unlikely that any of the developers still uses an older version than GCC 4.8 or Clang 3.4, since all supported distributions have at least these versions nowadays, so let's add a proper sanity check for these versions and get rid of code that is only there for older versions.

Note: I did not remove all "#if QEMU_GNUC_PREREQ(4, <8)" checks yet since some of them still apply to Clang, which reports itself as GCC 4.2. We should replace those checks with proper checks for the Clang version instead, in case newer versions of Clang support the corresponding feature - but that needs some time-consuming research first which I'll only start if this patch series gets accepted first.

v2:
- Don't remove CONFIG_INT128 sections, they are still required for 32-bit hosts
- Check for Apple's Xcode version of Clang

Thomas Huth (7):
configure: Add a test for the minimum compiler version
configure: Remove obsolete check for Clang < 3.2
configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro audio/alsaaudio: Remove compiler check around pragma
includes: Replace QEMU_GNUC_PREREQ with "__has_builtin ||

    !defined(__clang__)"

Remove QEMU_ARTIFICIAL macro

 Makefile.target            |  3 ---
 audio/alsaaudio.c          |  2 --
 configure                  | 57 ++++++++++++++++++++--------------------------
 include/qemu/compiler.h    |  8 +------
 include/qemu/host-utils.h  |  4 ++--
 scripts/checkpatch.pl      |  1 -
 scripts/cocci-macro-file.h |  1 -
 tcg/tcg.h                  |  4 +---
 8 files changed, 29 insertions(+), 51 deletions(-)
Signature · 1 line
1.8.3.1

Read the cover letter in its thread