leds: trigger: Add pattern initialization from Device Tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest5 patches 5 repliesIn review
- v65 patches 3 repliesSuperseded
- v55 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 5 patches | 2 replies | Superseded | |
| v3 | 5 patches | 6 replies | Superseded | |
| v2 | 5 patches | 5 replies | Applied |
Changes in v7 from the cover letter
1. Drop goto from led_get_default_pattern() and rename "DeviceTree" into "device tree".
2. Add Pavel's ack to patch 1/5.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dt-bindings: leds: Add pattern initialization from Device TreeDocumentation/ Documentation/ Documentation/ | +64 | 2 replies | |
| 2/5 | leds: Add helper for getting default pattern from Device Treedrivers/ include/ | +43 | 1 reply | |
| 3/5 | leds: trigger: pattern: Add pattern initialization from Device Treedrivers/ | +80 | 1 reply | |
| 4/5 | leds: trigger: oneshot: Add initialization from Device Treedrivers/ | +36 | 0 replies | |
| 5/5 | leds: trigger: timer: Add initialization from Device Treedrivers/ | +34 | 0 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Machek | Rob Herring |
|---|---|---|
| 1/5 | A-b | R-b |
| 2/5 | A-b | |
| 3/5 | A-b | |
| 4/5 | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/5] leds: trigger: Add pattern initialization from Device Tree
Hi,
Changes since v6:
1. Drop goto from led_get_default_pattern() and rename "DeviceTree" into "device tree".
2. Add Pavel's ack to patch 1/5.
Changes since v5:
1. Drop the "classdev" prefix from helper for getting default pattern and move the kerneldoc to header file (this was not fixed in v5 by mistake).
Changes since v4:
1. Move helper to get default pattern from led-class.c to led-core.c and rename it (build issue pointed by kbuild robot).
Changes since v3:
1. Add missing EXPORT_SYMBOL_GPL.
2. Put pattern trigger format into common file - shared between dt-bindings and sysfs.
3. Use array of integers as led-pattern property (since it is bigger change I did not add Pavel's ack to patch 2/5).
4. Mention ms units for led-pattern bindings.
Changes since v2:
1. Drop Jacek's patches and my "led: triggers: Initialize LED_INIT_DEFAULT_TRIGGER if trigger is brought after class".
2. Follow Rob's advices about bindings - use "led-pattern" property and generalize usage of it into to three triggers.
3. New patches (2/5, 4/5 and 5/5).
Changes since v1:
1. Rebase on Jacek's patches.
2. Add patch 3/5 for fixup of Jacek's solution.
3. Drop first two patches from the series (applied).
4. Patch 5/5: Use LED_INIT_DEFAULT_TRIGGER (suggested by Jacek Anaszewski).
5. Patch 5/5: Return-on-error and log warning (suggested by Pavel Machek).
Best regards,
Krzysztof
Krzysztof Kozlowski (5):
dt-bindings: leds: Add pattern initialization from Device Tree
leds: Add helper for getting default pattern from Device Tree
leds: trigger: pattern: Add pattern initialization from Device Tree
leds: trigger: oneshot: Add initialization from Device Tree
leds: trigger: timer: Add initialization from Device Tree
.../ABI/testing/sysfs-class-led-trigger-pattern | 51 +---------- Documentation/devicetree/bindings/leds/common.txt | 12 +++ .../bindings/leds/leds-trigger-pattern.txt | 49 +++++++++++ drivers/leds/led-core.c | 30 +++++++ drivers/leds/trigger/ledtrig-oneshot.c | 38 ++++++++- drivers/leds/trigger/ledtrig-pattern.c | 99 +++++++++++++++++----- drivers/leds/trigger/ledtrig-timer.c | 34 ++++++++ include/linux/leds.h | 13 +++ 8 files changed, 257 insertions(+), 69 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt
Signature · 1 line
2.7.4