Skip to content

arm64: kprobes: Update blacklist checking on arm64

Masami Hiramatsu linux-arm-kernel lkml 3 versions – In review

Get series with b4
b4 am 154998617300.21869.11457765723750331236.stgit@devbox

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesIn review
  2. v24 patches 11 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- [4/4] Fixes to remove redundant blacklist of kprobe_text and add blacklist on exception_text.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4arm64: kprobes: Move extable address check into arch_prepare_kprobe()arch/arm64/kernel/probes/kprobes.c+5 -20 replies
2/4arm64: kprobes: Remove unneeded RODATA checkarch/arm64/kernel/probes/kprobes.c+0 -60 replies
3/4arm64: kprobes: Move exception_text check in blacklistarch/arm64/kernel/probes/kprobes.c+2 -40 replies
4/4arm64: kprobes: Use arch_populate_kprobe_blacklist()arch/arm64/kernel/probes/kprobes.c+26 -192 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchJames MorseWill Deacon
1/4R-b
2/4
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] arm64: kprobes: Update blacklist checking on arm64

Hello,

Here is the v3 series of update of the kprobe blacklist checking on arm64.

I found that some blacklist checking code were mis-placed in arch_prepare_kprobe() and arch_within_kprobe_blacklist(). Since the blacklist just filters by symbol, smaller than the symbol, like extable must be checked in arch_prepare_kprobe(). Also, all function (symbol) level check must be done by blacklist.

For arm64, it checks the extable entry address in blacklist and exception/irqentry function in arch_prepare_kprobe(). And, RODATA check is unneeded since kernel/kprobes.c already ensures the probe address is in kernel-text area.

In v3, I rebased on the latest arm64 kernel which includes James' KVM/HYP fixes for kprobes, and fix a reported bugs in [4/4].

Changes in v3:
- [4/4] Fixes to remove redundant blacklist of kprobe_text and add blacklist on exception_text.

Thank you,

---

Masami Hiramatsu (4):
arm64: kprobes: Move extable address check into arch_prepare_kprobe()
arm64: kprobes: Remove unneeded RODATA check
arm64: kprobes: Move exception_text check in blacklist
arm64: kprobes: Use arch_populate_kprobe_blacklist()

 arch/arm64/kernel/probes/kprobes.c |   52 +++++++++++++++++++-----------------
 1 file changed, 27 insertions(+), 25 deletions(-)

--
Masami Hiramatsu (Linaro) <[email protected]>