Skip to content

Force the C standard to gnu99

Thomas Huth qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 19 repliesIn review
  2. v43 patches 8 repliesSuperseded
  3. v32 patches 16 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch4 repliesSuperseded
v11 patch12 repliesSuperseded

Changes in v5 from the cover letter

- Prefer to include headers instead of plain struct forward declarations in the second patch.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ppc: Move spapr-related prototypes from xics.h into a seperate header filehw/intc/xics_kvm.c hw/intc/xics_spapr.c hw/ppc/spapr_irq.c +2 more+40 -72 replies
2/3ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 modeinclude/hw/ppc/spapr.h include/hw/ppc/spapr_xive.h target/ppc/cpu.h+12 -814 replies
3/3configure: Force the C standard to gnu99configure+4 -13 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGreg KurzCédric Le GoaterPhilippe Mathieu-DaudéRichard HendersonDaniel P. BerrangéAlex Bennée
1/3R-b R-b R-b R-b
2/3R-b R-b R-b R-b
3/3R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/3] Force the C standard to gnu99

Different versions of GCC and Clang use different versions of the C standard by default. To avoid compilation problems with different compilers in the future, we should enforce one language level for all compilers. Since "gnu99" is the only usable option right now (later versions are still marked as experimental in GCC v4.8), we enforce compiling with -std=gnu99 now (in the third patch). This caused some new warnings/erros to appear with clang, which are fixed by the first two patches.

v5:
- Prefer to include headers instead of plain struct forward declarations in the second patch.

v4:
- Avoid circular inclusion of headers and introduce xics_spapr.h

v3:
- Compile C++ code with -std=gnu++98

v2:
- Use gnu99 instead of gnu11

Thomas Huth (3):
ppc: Move spapr-related prototypes from xics.h into a seperate header
file
ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99
mode
configure: Force the C standard to gnu99

 configure                   |  5 ++++-
 hw/intc/xics_kvm.c          |  1 +
 hw/intc/xics_spapr.c        |  1 +
 hw/ppc/spapr_irq.c          |  1 +
 include/hw/ppc/spapr.h      |  5 +++--
 include/hw/ppc/spapr_xive.h |  2 --
 include/hw/ppc/xics.h       |  7 -------
 include/hw/ppc/xics_spapr.h | 37 +++++++++++++++++++++++++++++++++++++
 target/ppc/cpu.h            | 13 +++++++++----
 9 files changed, 56 insertions(+), 16 deletions(-)
 create mode 100644 include/hw/ppc/xics_spapr.h
Signature · 1 line
1.8.3.1