Skip to content

locking/qspinlock: Handle > 4 nesting levels

Waiman Long linux-arch lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesIn review
  2. v24 patches 6 repliesSuperseded
  3. v15 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Fix typo error in patch 2.
- Rework patches 3/4 to create a new lockevent_* API to handle lock event counting that can be used by other locking code as well as on all architectures that are applicable.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4locking/qspinlock: Handle > 4 slowpath nesting levelskernel/locking/qspinlock.c+15 -00 replies
2/4locking/qspinlock_stat: Track the no MCS node available casekernel/locking/qspinlock.c kernel/locking/qspinlock_stat.h+17 -70 replies
3/4locking/qspinlock_stat: Introduce a generic lockevent counting APIskernel/locking/lock_events.h kernel/locking/lock_events_list.h kernel/locking/qspinlock.c +2 more+171 -1140 replies
4/4locking/lock_events: Make lock_events available for all archs & other locksarch/Kconfig arch/x86/Kconfig kernel/locking/Makefile +3 more+178 -1400 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchWill Deacon
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] locking/qspinlock: Handle > 4 nesting levels

v3:
- Fix typo error in patch 2.
- Rework patches 3/4 to create a new lockevent_* API to handle lock event counting that can be used by other locking code as well as on all architectures that are applicable.

v2:
- Use the simple trylock loop as suggested by PeterZ.

The current allows up to 4 levels of nested slowpath spinlock calls. That should be enough for the process, soft irq, hard irq, and nmi. With the unfortunate event of nested NMIs happening with slowpath spinlock call in each of the previous level, we are going to run out of useable MCS node for queuing.

In this case, we fall back to a simple TAS lock and spin on the lock cacheline until the lock is free. This is not most elegant solution but is simple enough.

Patch 1 implements the TAS loop when all the existing MCS nodes are occupied.

Patch 2 adds a new counter to track the no MCS node available event.

Patches 3 & 4 create a a new lockevent_* API to handle lock event counting that can be used by other locking code as well as on all architectures that are applicable.

By setting MAX_NODES to 1, we can have some usage of the new code path during the booting process as demonstrated by the stat counter values shown below on an 1-socket 22-core 44-thread x86-64 system after booting up the new kernel.

lock_no_node=20
lock_pending=29660
lock_slowpath=172714

Waiman Long (4):
locking/qspinlock: Handle > 4 slowpath nesting levels locking/qspinlock_stat: Track the no MCS node available case locking/qspinlock_stat: Introduce a generic lockevent counting APIs locking/lock_events: Make lock_events available for all archs & other
locks

 arch/Kconfig                        |  10 ++
 arch/x86/Kconfig                    |   8 --
 kernel/locking/Makefile             |   1 +
 kernel/locking/lock_events.c        | 152 +++++++++++++++++++++++
 kernel/locking/lock_events.h        |  46 +++++++
 kernel/locking/lock_events_list.h   |  49 ++++++++
 kernel/locking/qspinlock.c          |  22 +++-
 kernel/locking/qspinlock_paravirt.h |  19 +--
 kernel/locking/qspinlock_stat.h     | 233 +++++++-----------------------------
 9 files changed, 330 insertions(+), 210 deletions(-)
 create mode 100644 kernel/locking/lock_events.c
 create mode 100644 kernel/locking/lock_events.h
 create mode 100644 kernel/locking/lock_events_list.h
Signature · 1 line
1.8.3.1