Skip to content

Implement support for external IPT monitoring

Michał Leszczyński xen-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 21 repliesIn review
  2. v511 patches 19 repliesSuperseded
  3. v410 patches 64 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches10 repliesSuperseded
v27 patches38 repliesSuperseded
v17 patches51 repliesSuperseded

Changes in v6 from the cover letter

* trace buffer size is now dynamically determined by the proctrace tool
* trace buffer size variable is uniformly defined as uint32_t processor_trace_buf_kb in hypervisor, toolstack and ABI
* buffer pages are not freed explicitly but reference count is now used instead
* minor fixes according to code review

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11memory: batch processing in acquire_resource()xen/common/memory.c+44 -55 replies
2/11x86/vmx: add Intel PT MSR definitionsxen/include/asm-x86/msr-index.h+24 -00 replies
3/11x86/vmx: add IPT cpu featurexen/arch/x86/hvm/vmx/vmcs.c xen/common/domain.c xen/include/asm-x86/cpufeature.h +3 more+21 -12 replies
4/11common: add vmtrace_pt_size domain parameterxen/arch/x86/domain.c xen/common/domain.c xen/include/public/domctl.h +1 more+19 -02 replies
5/11tools/libxl: add vmtrace_pt_size parameterdocs/man/xl.cfg.5.pod.in tools/golang/xenlight/helpers.gen.go tools/golang/xenlight/types.gen.go +4 more+51 -01 reply
6/11x86/hvm: processor trace interface in HVMxen/arch/x86/domain.c xen/common/domain.c xen/include/asm-x86/hvm/hvm.h +1 more+80 -02 replies
7/11x86/vmx: implement IPT in VMXxen/arch/x86/hvm/vmx/vmx.c xen/include/asm-x86/hvm/vmx/vmcs.h xen/include/asm-x86/hvm/vmx/vmx.h+127 -02 replies
8/11x86/mm: add vmtrace_buf resource typexen/common/memory.c xen/include/public/memory.h+32 -01 reply
9/11x86/domctl: add XEN_DOMCTL_vmtrace_opxen/arch/x86/domctl.c xen/include/public/domctl.h+78 -02 replies
10/11tools/libxc: add xc_vmtrace_* functionstools/libxc/Makefile tools/libxc/include/xenctrl.h tools/libxc/xc_vmtrace.c+128 -01 reply
11/11tools/proctrace: add proctrace tooltools/proctrace/Makefile tools/proctrace/proctrace.c+224 -01 reply

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchAndrew CooperRoger Pau Monné
1/11
2/11A-b
3/11R-b
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/11] Implement support for external IPT monitoring

Intel Processor Trace is an architectural extension available in modern Intel family CPUs. It allows recording the detailed trace of activity while the processor executes the code. One might use the recorded trace to reconstruct the code flow. It means, to find out the executed code paths, determine branches taken, and so forth.

The abovementioned feature is described in Intel(R) 64 and IA-32 Architectures Software Developer's Manual Volume 3C: System Programming Guide, Part 3, Chapter 36: "Intel Processor Trace."

This patch series implements an interface that Dom0 could use in order to enable IPT for particular vCPUs in DomU, allowing for external monitoring. Such a feature has numerous applications like malware monitoring, fuzzing, or performance testing.

Also thanks to Tamas K Lengyel for a few preliminary hints before first version of this patch was submitted to xen-devel.

Changed since v1:
* MSR_RTIT_CTL is managed using MSR load lists
* other PT-related MSRs are modified only when vCPU goes out of context
* trace buffer is now acquired as a resource
* added vmtrace_pt_size parameter in xl.cfg, the size of trace buffer must be specified in the moment of domain creation
* trace buffers are allocated on domain creation, destructed on domain destruction
* HVMOP_vmtrace_ipt_enable/disable is limited to enabling/disabling PT these calls don't manage buffer memory anymore
* lifted 32 MFN/GFN array limit when acquiring resources
* minor code style changes according to review

Changed since v2:
* trace buffer is now allocated on domain creation (in v2 it was allocated when hvm param was set)
* restored 32-item limit in mfn/gfn arrays in acquire_resource and instead implemented hypercall continuations
* code changes according to Jan's and Roger's review

Changed since v3:
* vmtrace HVMOPs are not implemented as DOMCTLs
* patches splitted up according to Andrew's comments
* code changes according to v3 review on the mailing list

Changed since v4:
* rebased to commit be63d9d4
* fixed dependencies between patches (earlier patches don't reference further patches)
* introduced preemption check in acquire_resource
* moved buffer allocation to common code
* splitted some patches according to code review
* minor fixes according to code review

Changed since v5:
* trace buffer size is now dynamically determined by the proctrace tool
* trace buffer size variable is uniformly defined as uint32_t processor_trace_buf_kb in hypervisor, toolstack and ABI
* buffer pages are not freed explicitly but reference count is now used instead
* minor fixes according to code review

This patch series is available on GitHub:
https://github.com/icedevml/xen/tree/ipt-patch-v6

Michal Leszczynski (11):
memory: batch processing in acquire_resource()
x86/vmx: add Intel PT MSR definitions
x86/vmx: add IPT cpu feature
common: add vmtrace_pt_size domain parameter
tools/libxl: add vmtrace_pt_size parameter
x86/hvm: processor trace interface in HVM
x86/vmx: implement IPT in VMX
x86/mm: add vmtrace_buf resource type
x86/domctl: add XEN_DOMCTL_vmtrace_op
tools/libxc: add xc_vmtrace_* functions
tools/proctrace: add proctrace tool

 docs/man/xl.cfg.5.pod.in                    |  13 ++
 tools/golang/xenlight/helpers.gen.go        |   2 +
 tools/golang/xenlight/types.gen.go          |   1 +
 tools/libxc/Makefile                        |   1 +
 tools/libxc/include/xenctrl.h               |  40 +++++
 tools/libxc/xc_vmtrace.c                    |  87 ++++++++++
 tools/libxl/libxl.h                         |   8 +
 tools/libxl/libxl_create.c                  |   1 +
 tools/libxl/libxl_types.idl                 |   4 +
 tools/proctrace/Makefile                    |  45 +++++
 tools/proctrace/proctrace.c                 | 179 ++++++++++++++++++++
 tools/xl/xl_parse.c                         |  22 +++
 xen/arch/x86/domain.c                       |  27 +++
 xen/arch/x86/domctl.c                       |  50 ++++++
 xen/arch/x86/hvm/vmx/vmcs.c                 |  15 +-
 xen/arch/x86/hvm/vmx/vmx.c                  | 110 ++++++++++++
 xen/common/domain.c                         |  46 +++++
 xen/common/memory.c                         |  80 ++++++++-
 xen/include/asm-x86/cpufeature.h            |   1 +
 xen/include/asm-x86/hvm/hvm.h               |  20 +++
 xen/include/asm-x86/hvm/vmx/vmcs.h          |   4 +
 xen/include/asm-x86/hvm/vmx/vmx.h           |  14 ++
 xen/include/asm-x86/msr-index.h             |  24 +++
 xen/include/public/arch-x86/cpufeatureset.h |   1 +
 xen/include/public/domctl.h                 |  29 ++++
 xen/include/public/memory.h                 |   1 +
 xen/include/xen/domain.h                    |   2 +
 xen/include/xen/sched.h                     |   7 +
 28 files changed, 828 insertions(+), 6 deletions(-)
 create mode 100644 tools/libxc/xc_vmtrace.c
 create mode 100644 tools/proctrace/Makefile
 create mode 100644 tools/proctrace/proctrace.c
Signature · 1 line
2.17.1