Skip to content

Kconfig dependencies for ARM machines

Thomas Huth qemu-arm qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest30 patches 5 repliesIn review
  2. v529 patches 44 repliesSuperseded
  3. v429 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v330 patches1 replySuperseded
v225 patches5 repliesSuperseded
v125 patches6 repliesSuperseded

Changes in v6 from the cover letter

- Addressed the review feedback from Phillipe in v5
- Added Reviewed-bys and Tested-bys
- Use the "split" ohci patches instead of the single big one

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubshw/pci/pci-stub.c+11 -00 replies
2/30hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 devicehw/ide/Kconfig hw/ide/Makefile.objs+6 -21 reply
3/30hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in ohci_die()hw/usb/hcd-ohci.c+27 -120 replies
4/30hw/usb/hcd-ohci: Move PCI-related code into a separate filehw/sh4/Kconfig hw/usb/Kconfig hw/usb/Makefile.objs +3 more+284 -2080 replies
5/30hw/arm: Express dependencies of the exynos machines with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+16 -110 replies
6/30hw/arm: Express dependencies of the highbank machines with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+12 -80 replies
7/30hw/arm: Express dependencies of integratorcp with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/display/Kconfig+10 -70 replies
8/30hw/arm: Express dependencies of the fsl-imx31 machine with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/misc/Kconfig+7 -20 replies
9/30hw/arm: Express dependencies of musicpal with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+6 -50 replies
10/30hw/arm: Express dependencies of the OMAP machines with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+31 -140 replies
11/30hw/arm: Express dependencies of stellaris with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+12 -61 reply
12/30hw/arm: Express dependencies of realview, versatile and vexpress with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs +2 more+57 -210 replies
13/30hw/arm: Express dependencies of the PXA2xx machines with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+51 -110 replies
14/30hw/arm: Express dependencies of xilinx-zynq with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+13 -60 replies
15/30hw/arm: Express dependencies of collie with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+9 -30 replies
16/30hw/arm: Express dependencies of the aspeed boards with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+11 -60 replies
17/30hw/arm: Express dependencies of the virt machine with Kconfigdefault-configs/aarch64-softmmu.mak default-configs/arm-softmmu.mak hw/arm/Kconfig +1 more+22 -120 replies
18/30hw/arm: Express dependencies of netduino / stm32f2xx with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+8 -80 replies
19/30hw/arm: Express dependencies of allwinner / cubieboard with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+10 -50 replies
20/30hw/arm: Express dependencies of the MPS2 boards with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+20 -190 replies
21/30hw/arm: Express dependencies of the raspi machines with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+4 -30 replies
22/30hw/arm: Express dependencies of canon-a1100 with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+2 -10 replies
23/30hw/arm: Express dependencies of sabrelite with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+12 -40 replies
24/30hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+11 -30 replies
25/30hw/arm: Express dependencies of the remaining IMX boards with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig+19 -20 replies
26/30hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfigdefault-configs/arm-softmmu.mak hw/arm/Kconfig hw/arm/Makefile.objs+9 -30 replies
27/30hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfigdefault-configs/aarch64-softmmu.mak hw/arm/Kconfig hw/display/Kconfig+12 -40 replies
28/30hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfighw/arm/Kconfig+4 -00 replies
29/30hw/arm: Express dependencies of the musca machines with Kconfighw/arm/Kconfig+6 -30 replies
30/30hw/arm: Remove hard-enablement of the remaining PCI devicesdefault-configs/arm-softmmu.mak+0 -81 reply

Reviews trailers per patch

29 of 30 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinPhilippe Mathieu-DaudéPeter ChubbAlistair FrancisCédric Le GoaterJohn Snow
1/30R-b R-b T-b
2/30R-b T-b A-b
3/30R-b T-b
4/30R-b T-b
5/30R-b T-b
6/30R-b T-b
7/30R-b T-b
8/30R-b T-b R-b
9/30R-b T-b
10/30R-b T-b
11/30T-b R-b
12/30R-b T-b
13/30R-b T-b
14/30R-b T-b R-b
15/30R-b T-b
16/30R-b T-b R-b
17/30R-b T-b
18/30R-b T-b R-b
19/30R-b T-b
20/30R-b T-b
21/30R-b T-b R-b
22/30R-b T-b
23/30R-b T-b
24/30R-b T-b
25/30R-b T-b
26/30R-b T-b R-b
27/30R-b T-b R-b
28/30R-b T-b
29/30R-b T-b
30/30T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v6 thread

Cover letter [Qemu-arm] [PATCH v6 00/30] Kconfig dependencies for ARM machines

This series reworks the default-configs/arm-softmmu.mak and default-configs/aarch64-softmmu.mak files to use the new Kconfig-style dependencies instead.

Some of the patches are slightly based on the work by Ákos Kovács:

https://lists.nongnu.org/archive/html/qemu-devel/2013-08/msg03730.html

The other patches have been created by looking at the sources and finding out the dependencies the hard way via trial-and-error (i.e. by enabling only one machine at a time and checking whether it can be compiled and started).

v6:
- Addressed the review feedback from Phillipe in v5
- Added Reviewed-bys and Tested-bys
- Use the "split" ohci patches instead of the single big one

v5:
- Rebased the series to the current master branch
- Added "hw/usb/hcd-ohci: Move PCI-related code into a separate file" patch and got rid of unneeded dependencies to CONFIG_PCI in the ARM machines that do not have a PCI bus

v4:
- Rebased the series to Paolo's latest kconfig tree

v3:
- Addressed review feedback from v2
- Included patches to clean up the PCI dependencies of AHCI and SDHCI (so CONFIG_AHCI and CONFIG_SDHCI do not depend on CONFIG_PCI anymore)
- Added an additional patch for the new "musca" machines

v2: Adressed review-feedback from v1
- CONFIG_SDHCI and CONFIG_AHCI now select CONFIG_PCI
- Added switches for MICROBIT and EMCRAFT_SF2

Thomas Huth (30):
hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device hw/usb/hcd-ohci: Do not use PCI functions with sysbus devices in

    ohci_die()

hw/usb/hcd-ohci: Move PCI-related code into a separate file hw/arm: Express dependencies of the exynos machines with Kconfig hw/arm: Express dependencies of the highbank machines with Kconfig hw/arm: Express dependencies of integratorcp with Kconfig hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig hw/arm: Express dependencies of musicpal with Kconfig hw/arm: Express dependencies of the OMAP machines with Kconfig hw/arm: Express dependencies of stellaris with Kconfig hw/arm: Express dependencies of realview, versatile and vexpress with
Kconfig
hw/arm: Express dependencies of the PXA2xx machines with Kconfig hw/arm: Express dependencies of xilinx-zynq with Kconfig hw/arm: Express dependencies of collie with Kconfig hw/arm: Express dependencies of the aspeed boards with Kconfig hw/arm: Express dependencies of the virt machine with Kconfig hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig hw/arm: Express dependencies of allwinner / cubieboard with Kconfig hw/arm: Express dependencies of the MPS2 boards with Kconfig hw/arm: Express dependencies of the raspi machines with Kconfig hw/arm: Express dependencies of canon-a1100 with Kconfig hw/arm: Express dependencies of sabrelite with Kconfig hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with
Kconfig
hw/arm: Express dependencies of the remaining IMX boards with Kconfig hw/arm: Express dependencies of the microbit / nrf51 machine with
Kconfig
hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig hw/arm: Express dependencies of the xlnx-versal-virt machine with
Kconfig
hw/arm: Express dependencies of the musca machines with Kconfig hw/arm: Remove hard-enablement of the remaining PCI devices

 default-configs/aarch64-softmmu.mak |   5 -
 default-configs/arm-softmmu.mak     | 179 +++-------------
 hw/arm/Kconfig                      | 317 +++++++++++++++++++++++++++-
 hw/arm/Makefile.objs                |  25 ++-
 hw/display/Kconfig                  |   3 +
 hw/i2c/Kconfig                      |   2 +-
 hw/ide/Kconfig                      |   6 +-
 hw/ide/Makefile.objs                |   2 +-
 hw/misc/Kconfig                     |   2 +
 hw/pci/pci-stub.c                   |  11 +
 hw/sh4/Kconfig                      |   2 +-
 hw/usb/Kconfig                      |   6 +-
 hw/usb/Makefile.objs                |   1 +
 hw/usb/hcd-ohci-pci.c               | 163 ++++++++++++++
 hw/usb/hcd-ohci.c                   | 219 ++-----------------
 hw/usb/hcd-ohci.h                   | 104 +++++++++
 16 files changed, 676 insertions(+), 371 deletions(-)
 create mode 100644 hw/usb/hcd-ohci-pci.c
 create mode 100644 hw/usb/hcd-ohci.h
Signature · 1 line
2.21.0